New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the "Cannot start qrexec for domain XYZ, do you want to wait or not" message #790

Closed
marmarek opened this Issue Mar 8, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 2 Feb 2014 10:53 UTC
Nobody likes "modal" dialog boxes that ask strange questions nobody knows why!

Just display a notification message and automatically kill the VM and perhaps automatically attempt to start it again.

Migrated-From: https://wiki.qubes-os.org/ticket/790

@marmarek marmarek added this to the Release 2 Beta 3 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 2 Feb 2014 11:47 UTC
I don't think automatic restart is a good idea.
One use case when this dialog make sense: Windows HVM start. Sometimes it takes a long time for Windows to startup (for example when installing some updates, or running checkdisk) - the VM shouldn't be killed in such case, perhaps the user should increase qrexec_timeout setting (but still - killing the VM during such such startup can have bad effects).

Perhaps we should distinguish here between PV and HVM? For PV unconditionally kill the VM failing its startup, but for HVM just keep the message?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 2 Feb 2014 11:47 UTC
I don't think automatic restart is a good idea.
One use case when this dialog make sense: Windows HVM start. Sometimes it takes a long time for Windows to startup (for example when installing some updates, or running checkdisk) - the VM shouldn't be killed in such case, perhaps the user should increase qrexec_timeout setting (but still - killing the VM during such such startup can have bad effects).

Perhaps we should distinguish here between PV and HVM? For PV unconditionally kill the VM failing its startup, but for HVM just keep the message?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 2 Feb 2014 12:08 UTC
Keeping the message popping up is against UI ergonomy -- there is nothing here that a user should be able to decide better than software, so asking the user about it makes no sense and is only annoying.

Let's think more about this: does the user has any more clues to answer that question meaningfully than our software stack? If yes, then why can't we incorporate this logic into our software stack? If no, then asking user makes no sense anyway.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 2 Feb 2014 12:08 UTC
Keeping the message popping up is against UI ergonomy -- there is nothing here that a user should be able to decide better than software, so asking the user about it makes no sense and is only annoying.

Let's think more about this: does the user has any more clues to answer that question meaningfully than our software stack? If yes, then why can't we incorporate this logic into our software stack? If no, then asking user makes no sense anyway.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 2 Feb 2014 12:11 UTC
Yes the user have more clues: sees windows installing its updates (or sth like this). I don't see our tool doing OCR of windows screen...

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 2 Feb 2014 12:11 UTC
Yes the user have more clues: sees windows installing its updates (or sth like this). I don't see our tool doing OCR of windows screen...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 2 Feb 2014 12:15 UTC
So how about, instead of panicking and displaying this dialog to the user, just keep trying to connect qrexec/guid to the VM? I.e. the only signal that they didn't connect would be the yellow dot in the manager. Plus an error message appearing whenever user tries to qrexec to the VM (e.g. qvm-run something there). The error message should, of course, appear in the notification tray, like other error message, not via kdialog!

Member

marmarek commented Mar 8, 2015

Comment by joanna on 2 Feb 2014 12:15 UTC
So how about, instead of panicking and displaying this dialog to the user, just keep trying to connect qrexec/guid to the VM? I.e. the only signal that they didn't connect would be the yellow dot in the manager. Plus an error message appearing whenever user tries to qrexec to the VM (e.g. qvm-run something there). The error message should, of course, appear in the notification tray, like other error message, not via kdialog!

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 2 Feb 2014 12:20 UTC
Ok for me. But still one issue to solve: what about qvm-run -a VM some-program?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 2 Feb 2014 12:20 UTC
Ok for me. But still one issue to solve: what about qvm-run -a VM some-program?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 2 Feb 2014 12:21 UTC
Failed qvm-run -a --> tray notification after timeout.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 2 Feb 2014 12:21 UTC
Failed qvm-run -a --> tray notification after timeout.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 5 Feb 2014 02:33 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 5 Feb 2014 02:33 UTC

@marmarek marmarek self-assigned this Mar 8, 2015

@marmarek marmarek closed this Mar 8, 2015

@mdik

This comment has been minimized.

Show comment
Hide comment
@mdik

mdik Aug 5, 2017

Right now I'm running into timeouts when doing
qvm-create-default-dvm whonix-ws
and I would really appreciate either a longer timeout, or the option to wait a bit longer :-}

mdik commented Aug 5, 2017

Right now I'm running into timeouts when doing
qvm-create-default-dvm whonix-ws
and I would really appreciate either a longer timeout, or the option to wait a bit longer :-}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment