New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open more than one file in the same DispVM #814

Open
marmarek opened this Issue Mar 8, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 8 Apr 2014 09:14 UTC
Usecase: somebody sends me 10 photos via email and I would like to open all of them in one DispVM under Shotwell (or other default app) and be able to easily browse through them.

Migrated-From: https://wiki.qubes-os.org/ticket/814

@marmarek marmarek added this to the Release 2 rc1 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 8 Apr 2014 11:02 UTC
Are we really want it for R2-rc1? It doesn't look like 5min feature...
Problems:

  1. Current "open-in-vm" protocol allow only to pass one file, because we want the protocol simple AND allow to pass possibly modified file back.
  2. Source VM do not know DispVM name in which file was opened, so it can't simply "qvm-open-in-vm DISPVM_NAME" other files. But the user see the name (in window title bar), so can do it manually.

Situation is much better when you receive ''archive'' of 10 photos - you can simply open that archive in DispVM, extract it there and browse photos.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 8 Apr 2014 11:02 UTC
Are we really want it for R2-rc1? It doesn't look like 5min feature...
Problems:

  1. Current "open-in-vm" protocol allow only to pass one file, because we want the protocol simple AND allow to pass possibly modified file back.
  2. Source VM do not know DispVM name in which file was opened, so it can't simply "qvm-open-in-vm DISPVM_NAME" other files. But the user see the name (in window title bar), so can do it manually.

Situation is much better when you receive ''archive'' of 10 photos - you can simply open that archive in DispVM, extract it there and browse photos.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 8 Apr 2014 11:28 UTC
Yes, I was thinking about using the existing protocol, something ala compress and open-in-dispvm yo suggested. Just not sure if we could safely use the Linux default archiver program (say, tgz or zip) to compress a number of untrusted files. Hm... I think actually we should be able to do that, because AFAIU the packing operation should treat the files as "amorphic" stream of bytes without interpreting them in any way. Hm, but I could also imagine some "smart" archiver that tries to use a different algo params depending on whether it compresses photos vs. text vs. code, which might then involve actually parsing the files before compressing them, which would be not acceptable to us.

But, assuming we can be sure that, say, doing "tar cvzf archive-to-send.tgz files-see-*" doesn't parse the input files, perhaps we could have a handy script to handle this automagically? By this I mean: when a user selected a group o files (i.e. >1) then instead of "Open in DispVM" (which should be grayed) we have "Open files in DispVM".

Alternatively, if changing entries in Nautilus menu depending on the number of selected files was non-trivial, we could have the standard "Open in DispVM" behave differently depending on whether there is only one file selected vs. more-than-one-selected?

Member

marmarek commented Mar 8, 2015

Comment by joanna on 8 Apr 2014 11:28 UTC
Yes, I was thinking about using the existing protocol, something ala compress and open-in-dispvm yo suggested. Just not sure if we could safely use the Linux default archiver program (say, tgz or zip) to compress a number of untrusted files. Hm... I think actually we should be able to do that, because AFAIU the packing operation should treat the files as "amorphic" stream of bytes without interpreting them in any way. Hm, but I could also imagine some "smart" archiver that tries to use a different algo params depending on whether it compresses photos vs. text vs. code, which might then involve actually parsing the files before compressing them, which would be not acceptable to us.

But, assuming we can be sure that, say, doing "tar cvzf archive-to-send.tgz files-see-*" doesn't parse the input files, perhaps we could have a handy script to handle this automagically? By this I mean: when a user selected a group o files (i.e. >1) then instead of "Open in DispVM" (which should be grayed) we have "Open files in DispVM".

Alternatively, if changing entries in Nautilus menu depending on the number of selected files was non-trivial, we could have the standard "Open in DispVM" behave differently depending on whether there is only one file selected vs. more-than-one-selected?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 8 Apr 2014 11:31 UTC
Sounds doable. Still - do we want it for R2-rc1?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 8 Apr 2014 11:31 UTC
Sounds doable. Still - do we want it for R2-rc1?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 13 Apr 2014 10:54 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 13 Apr 2014 10:54 UTC

@marmarek marmarek modified the milestones: Release 2, Release 2 rc1 Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 20 Apr 2014 17:02 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 20 Apr 2014 17:02 UTC

@marmarek marmarek modified the milestones: Release 2.1 (post R2), Release 2 Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 20 Apr 2014 17:06 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 20 Apr 2014 17:06 UTC

@marmarek marmarek added the C: other label Mar 8, 2015

@marmarek marmarek modified the milestones: Release 4.0, Release 2.1 (post R2) Jul 30, 2015

andrewdavidwong added a commit that referenced this issue Jun 9, 2016

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 18, 2016

Member

On 2016-07-18 01:27, Jeremy Rand wrote:

Might there be any plans to allow sending a directory to a DispVM?
Right now in Qubes 3.2 rc1, attempting to do so from the file manager
GUI in a Fedora 23 template yields this error:

qopen-in-vm: Fatal error: send file to dispVM (error type: Is a directory)

The desired behavior, I think, would be to open a file manager window
inside the DispVM that includes the full contents of the selected
directory. This way, files could be edited in a DispVM that depend on
other nearby files (e.g. document files that reference image files).

Member

andrewdavidwong commented Jul 18, 2016

On 2016-07-18 01:27, Jeremy Rand wrote:

Might there be any plans to allow sending a directory to a DispVM?
Right now in Qubes 3.2 rc1, attempting to do so from the file manager
GUI in a Fedora 23 template yields this error:

qopen-in-vm: Fatal error: send file to dispVM (error type: Is a directory)

The desired behavior, I think, would be to open a file manager window
inside the DispVM that includes the full contents of the selected
directory. This way, files could be edited in a DispVM that depend on
other nearby files (e.g. document files that reference image files).

@mfc mfc referenced this issue Jan 31, 2017

Closed

create GSOC 2017 Ideas List #2607

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment