New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the situation when the template is shutdown when qubes.SyncAppMenus is still running #836

Closed
marmarek opened this Issue Mar 8, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 27 Apr 2014 17:04 UTC

  • Prevent template shutdown? Likely not do'ble thanks to the poweroff command in the template
  • Detect template shutdown and inform the user to re-run appmenus syncing.

Migrated-From: https://wiki.qubes-os.org/ticket/836

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 27 Apr 2014 17:05 UTC
If that's not obvious: otherwise this seriously break things -- e.g. template doesn't shutdown fully (the "gray" dot in the manager keeps going), and we cannot start it again.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 27 Apr 2014 17:05 UTC
If that's not obvious: otherwise this seriously break things -- e.g. template doesn't shutdown fully (the "gray" dot in the manager keeps going), and we cannot start it again.

@marmarek marmarek added this to the Release 2 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by joanna on 5 May 2014 12:10 UTC

Member

marmarek commented Mar 8, 2015

Modified by joanna on 5 May 2014 12:10 UTC

@marmarek marmarek added P: critical and removed P: major labels Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by woju on 6 May 2014 09:25 UTC

Member

marmarek commented Mar 8, 2015

Modified by woju on 6 May 2014 09:25 UTC

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 6 May 2014 16:44 UTC
VM stops with message "A stop job is running for Session c1 for user user". Closes within a minute or so.

Possibly related:

but reporter seems unreliable.

Member

marmarek commented Mar 8, 2015

Comment by woju on 6 May 2014 16:44 UTC
VM stops with message "A stop job is running for Session c1 for user user". Closes within a minute or so.

Possibly related:

but reporter seems unreliable.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 6 May 2014 16:58 UTC
https://bugs.freedesktop.org/show_bug.cgi?id=70593

May be unrelated to appmenus. It may be just the most common trigger, because it runs for long.

Member

marmarek commented Mar 8, 2015

Comment by woju on 6 May 2014 16:58 UTC
https://bugs.freedesktop.org/show_bug.cgi?id=70593

May be unrelated to appmenus. It may be just the most common trigger, because it runs for long.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 7 May 2014 08:53 UTC
The simplest but far from ideal solution: gray out the Stop button in the manager until the qubes.ReceiveAppmenus completes.

Better: also prevent the user from doing qvm-shutdown -> so some kind of lock in qubes.py

Ideal: also prevent the user from doing poweroff in the VM

Member

marmarek commented Mar 8, 2015

Comment by joanna on 7 May 2014 08:53 UTC
The simplest but far from ideal solution: gray out the Stop button in the manager until the qubes.ReceiveAppmenus completes.

Better: also prevent the user from doing qvm-shutdown -> so some kind of lock in qubes.py

Ideal: also prevent the user from doing poweroff in the VM

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 7 May 2014 08:56 UTC
The latter (preventing VM shutdown from within VM) might be done always, i.e. just remove this possibility regardless of whether the appmenus are syncing or not. So, always force the user to use the manager or qvm-shutdown for VM shutdowns.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 7 May 2014 08:56 UTC
The latter (preventing VM shutdown from within VM) might be done always, i.e. just remove this possibility regardless of whether the appmenus are syncing or not. So, always force the user to use the manager or qvm-shutdown for VM shutdowns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment