New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager cannot copy logs to clipboard #846

Closed
marmarek opened this Issue Mar 8, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 7 May 2014 08:39 UTC
When I click Copy to Clipboard in a log viewing windows I get an exception:

OSError: [13](Errno) Permission denied: '/var/run/qubes/appviewer.lock'
at line 60
of file /usr/lib64/python2.7/site-packages/qubesmanager/log_dialog.py.

Migrated-From: https://wiki.qubes-os.org/ticket/846

@marmarek marmarek added this to the Release 2 milestone Mar 8, 2015

@marmarek marmarek added the bug label Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 7 May 2014 10:40 UTC
What version of qubes-gui-dom0 you had during last reboot?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 7 May 2014 10:40 UTC
What version of qubes-gui-dom0 you had during last reboot?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by woju on 8 May 2014 14:46 UTC

Member

marmarek commented Mar 8, 2015

Modified by woju on 8 May 2014 14:46 UTC

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 8 May 2014 14:51 UTC
Take look at this commit:
http://git.qubes-os.org/?p=marmarek/gui-daemon.git;a=commit;h=33e4653ea58950ea4a37b7832132de5f241c4c15
IMO it should be enough, but will work after reboot - hence the question about qubes-gui-dom0 version.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 8 May 2014 14:51 UTC
Take look at this commit:
http://git.qubes-os.org/?p=marmarek/gui-daemon.git;a=commit;h=33e4653ea58950ea4a37b7832132de5f241c4c15
IMO it should be enough, but will work after reboot - hence the question about qubes-gui-dom0 version.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 8 May 2014 16:04 UTC
Marek, could you please accept bugs that you work on? :)

Member

marmarek commented Mar 8, 2015

Comment by woju on 8 May 2014 16:04 UTC
Marek, could you please accept bugs that you work on? :)

@marmarek marmarek assigned marmarek and unassigned woju Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 8 May 2014 20:23 UTC
Commit time: Apr 16
Ticket created: May 7

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 8 May 2014 20:23 UTC
Commit time: Apr 16
Ticket created: May 7

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 9 May 2014 07:22 UTC
Replying to marmarek:

Commit time: Apr 16
Ticket created: May 7

Oh, you're right. Sorry. :)

Member

marmarek commented Mar 8, 2015

Comment by woju on 9 May 2014 07:22 UTC
Replying to marmarek:

Commit time: Apr 16
Ticket created: May 7

Oh, you're right. Sorry. :)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 12 May 2014 19:34 UTC
So, what with this ticket? Does this problem still exists?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 12 May 2014 19:34 UTC
So, what with this ticket? Does this problem still exists?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 13 May 2014 12:46 UTC
Just rebooted my system to test this, and... it still throws an exception:

----
line: fd = os.open("/var/run/qubes/appviewer.lock", os.O_RDWR|os.O_CREAT, 0600)
func: copy_text_to_qubes_clipboard
line no.: 77
file: /usr/lib64/python2.7/site-packages/qubesmanager/log_dialog.py
----
line: copy_text_to_qubes_clipboard(self.displayed_text)
func: copy_to_qubes_clipboard_triggered
line no.: 69
file: /usr/lib64/python2.7/site-packages/qubesmanager/log_dialog.py

Hm, perhaps we need also to change the code in the manager?

[~](joanna@dom0)$ rpm -q qubes-manager qubes-gui-dom0
qubes-manager-2.0.29-1.x86_64
qubes-gui-dom0-2.1.29-1.fc20.x86_64
[~](joanna@dom0)$ ll /var/run/qubes/appviewer.lock 
-rw------- 1 root joanna 0 May 13 14:35 /var/run/qubes/appviewer.lock
Member

marmarek commented Mar 8, 2015

Comment by joanna on 13 May 2014 12:46 UTC
Just rebooted my system to test this, and... it still throws an exception:

----
line: fd = os.open("/var/run/qubes/appviewer.lock", os.O_RDWR|os.O_CREAT, 0600)
func: copy_text_to_qubes_clipboard
line no.: 77
file: /usr/lib64/python2.7/site-packages/qubesmanager/log_dialog.py
----
line: copy_text_to_qubes_clipboard(self.displayed_text)
func: copy_to_qubes_clipboard_triggered
line no.: 69
file: /usr/lib64/python2.7/site-packages/qubesmanager/log_dialog.py

Hm, perhaps we need also to change the code in the manager?

[~](joanna@dom0)$ rpm -q qubes-manager qubes-gui-dom0
qubes-manager-2.0.29-1.x86_64
qubes-gui-dom0-2.1.29-1.fc20.x86_64
[~](joanna@dom0)$ ll /var/run/qubes/appviewer.lock 
-rw------- 1 root joanna 0 May 13 14:35 /var/run/qubes/appviewer.lock
@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment