New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposable VMs should inherit the netVM from the AppVM which created it #862

Closed
marmarek opened this Issue Mar 8, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

@marmarek marmarek added this to the Release 2.1 (post R2) milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 29 May 2014 11:01 UTC
I think we want to move this to R3...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 29 May 2014 11:01 UTC
I think we want to move this to R3...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 29 May 2014 12:30 UTC
This seems to be very important feature, especially for torvm users (even when workaround exists), so I think we should keep this in R2.1 milestone.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 29 May 2014 12:30 UTC
This seems to be very important feature, especially for torvm users (even when workaround exists), so I think we should keep this in R2.1 milestone.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 26 Sep 2014 02:16 UTC
When netvm will be inherited from calling VM, it would be no longer needed to set firewall to "block all" when netvm is set to "none".
The question is: do we want make this the only option, or keep both approaches and let the user choose? Removing the old approach will cleanup the code (that feature is really hacky), but on the other hand, keeping it would be beneficial sometimes. For example for network disconnected DispVMs (PDF converter?).
Or perhaps we want to remove old behavior, and implement it in cleaner way, once #866 done?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 26 Sep 2014 02:16 UTC
When netvm will be inherited from calling VM, it would be no longer needed to set firewall to "block all" when netvm is set to "none".
The question is: do we want make this the only option, or keep both approaches and let the user choose? Removing the old approach will cleanup the code (that feature is really hacky), but on the other hand, keeping it would be beneficial sometimes. For example for network disconnected DispVMs (PDF converter?).
Or perhaps we want to remove old behavior, and implement it in cleaner way, once #866 done?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 19 Jan 2015 00:18 UTC
Ok, moving to R3 because that change in R2 code base would be totally different in R3, so don't do the job twice.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 19 Jan 2015 00:18 UTC
Ok, moving to R3 because that change in R2 code base would be totally different in R3, so don't do the job twice.

@marmarek marmarek modified the milestones: Release 3, Release 2.1 (post R2) Mar 8, 2015

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Apr 4, 2015

@qjoo

This comment has been minimized.

Show comment
Hide comment
@qjoo

qjoo May 3, 2015

I'm still getting a networked dispvm even after creating it from a offline appvm? (in 3.0-rc1)

qjoo commented May 3, 2015

I'm still getting a networked dispvm even after creating it from a offline appvm? (in 3.0-rc1)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 3, 2015

Member

On Sun, May 03, 2015 at 04:22:46AM -0700, qjoo wrote:

I'm still getting a networked dispvm even after creating it from a
offline appvm? (in 3.0-rc1)

Are you sure that the DispVM really have network access? Indeed I see
'eth0' there in such case, but it isn't connected anywhere.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented May 3, 2015

On Sun, May 03, 2015 at 04:22:46AM -0700, qjoo wrote:

I'm still getting a networked dispvm even after creating it from a
offline appvm? (in 3.0-rc1)

Are you sure that the DispVM really have network access? Indeed I see
'eth0' there in such case, but it isn't connected anywhere.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue May 4, 2015

dispvm: fix netvm presence reporting
If desired netvm presence is different than during savefile creation(*),
defer setting the netvm until new DispVM is running - otherwise kernel
there will not notice the change and will either have (not working)
'eth0' when it shouldn't, or will not have it while it should.

Additionally set dispvm.uses_default_netvm = False, so GUI tools will
display actual netvm value.

(*) Actually compare to netvm set for dispvm template (`TEMPLATE-dvm`
VM), which can be different if user just changed that but not
regenerated dispvm savefile yet.

Fixes QubesOS/qubes-issues#985
Related to QubesOS/qubes-issues#862

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Mar 7, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 11, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment