qvm-backup doesn't check if there is enough space on dest if backing up to a VM

[marmarek]

Reported by joanna on 1 Jun 2014 09:51 UTC
None

Migrated-From: https://wiki.qubes-os.org/ticket/864

[marmarek]

Comment by marmarek on 1 Jun 2014 11:27 UTC
Yes, that's true. Any idea how it can check that, specially when custom store command used?

BTW When compression is enabled, backup will use about half or original data size. So it's not always a good idea to prevent starting backup when theoretically no enough space is available.

[marmarek]

Comment by marmarek on 1 Jun 2014 11:27 UTC
Yes, that's true. Any idea how it can check that, specially when custom store command used?

BTW When compression is enabled, backup will use about half or original data size. So it's not always a good idea to prevent starting backup when theoretically no enough space is available.

[marmarek]

Modified by joanna on 30 Jun 2014 11:47 UTC

[marmarek]

Modified by joanna on 30 Jun 2014 11:47 UTC

[marmarek]

Modified by woju on 30 Jun 2014 13:19 UTC

[marmarek]

Modified by woju on 30 Jun 2014 13:19 UTC

[nothingmuch]

I've had two issues that I think are related, as based on the comment about compression, I believe this is mostly about clearly reporting errors, not so much predicting them

1. i tried backing up to FAT32 disk I had around, and at the 4G file limit the backup just failed, with no indication of what error occurred,
2. Attempting a backup to ext4 failed immediately, again with no error reported, which chown -R user:user on the fresh ext4 partition rectified.

In fact, the second error has been plaguing me for a number of attempts over several weeks, and finally today when I accidentally tried a FAT32 disk and it partly worked, I only realized what was going on after i had partial success. I'm not sure why I assumed the backup would run as root in the target vm, but I do think there's room for UI improvements. I did not have time to debug the actual backup program and find out why errors were being ellided, unfortunately.

[nothingmuch]

I've had two issues that I think are related, as based on the comment about compression, I believe this is mostly about clearly reporting errors, not so much predicting them

1. i tried backing up to FAT32 disk I had around, and at the 4G file limit the backup just failed, with no indication of what error occurred,
2. Attempting a backup to ext4 failed immediately, again with no error reported, which chown -R user:user on the fresh ext4 partition rectified.

In fact, the second error has been plaguing me for a number of attempts over several weeks, and finally today when I accidentally tried a FAT32 disk and it partly worked, I only realized what was going on after i had partial success. I'm not sure why I assumed the backup would run as root in the target vm, but I do think there's room for UI improvements. I did not have time to debug the actual backup program and find out why errors were being ellided, unfortunately.

[unman]

@andrewdavidwong Confirmed issue still arises in 3.2 milestone

[unman]

@andrewdavidwong Confirmed issue still arises in 3.2 milestone

[woju]

This issue is abandoned, so I'm going to close it. If that's a mistake, feel free to reopen.
@marmarek @andrewdavidwong

[woju]

This issue is abandoned, so I'm going to close it. If that's a mistake, feel free to reopen.
@marmarek @andrewdavidwong