Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFirefox in the default DispVM displays a post-crash error message #872
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 30 Jun 2014 12:53 UTC
Most likely it will not help. We need clean shutdown of firefox (and others) rather than simply killing Xorg...
Relevant file is core-agent-linux/misc/dispvm-prerun.sh.
|
Comment by marmarek on 30 Jun 2014 12:53 UTC |
marmarek
added this to the Release 2 milestone
Mar 8, 2015
marmarek
added
bug
C: core
P: major
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by woju on 30 Jun 2014 14:30 UTC
firefox can be "gracefully killed" via xkill:
xkill -id $(xwininfo -root -children | fgrep '"Navigator"' | awk '{ print $1 }')but it must be done from inside the VM, xkill from dom0 kills guid
|
Comment by woju on 30 Jun 2014 14:30 UTC xkill -id $(xwininfo -root -children | fgrep '"Navigator"' | awk '{ print $1 }')but it must be done from inside the VM, xkill from dom0 kills |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 30 Jun 2014 14:31 UTC
That script I've pointed is running inside of VM.
|
Comment by marmarek on 30 Jun 2014 14:31 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by woju on 30 Jun 2014 14:37 UTC
Hmmm, can we just kill all windows before killall Xorg in core-agent-linux/vm-systemd/prepare-dvm.sh?
|
Comment by woju on 30 Jun 2014 14:37 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Comment by marmarek on 30 Jun 2014 14:41 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by marmarek on 4 Jul 2014 13:51 UTC |
marmarek
self-assigned this
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 4 Jul 2014 18:39 UTC
xkill wasn't enough - Firefox still handled that as crash. No surprise - xkill forcefully terminate x11 connection to particular client (XKillClient call).
Done by sending proper WM_DELETE_WINDOW message - same as window manager in response to "close" button of window decoration.
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fd42d99803bd856c977e6fb3db6a4b12612ad6b1
|
Comment by marmarek on 4 Jul 2014 18:39 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 30 Jun 2014 11:40 UTC
... which looks pretty inelegant. Shall we extend the dispvm savefile creation timeout to ensure clean FF exit?
Migrated-From: https://wiki.qubes-os.org/ticket/872