New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox in the default DispVM displays a post-crash error message #872

Closed
marmarek opened this Issue Mar 8, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 30 Jun 2014 11:40 UTC
... which looks pretty inelegant. Shall we extend the dispvm savefile creation timeout to ensure clean FF exit?

Migrated-From: https://wiki.qubes-os.org/ticket/872

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 30 Jun 2014 12:53 UTC
Most likely it will not help. We need clean shutdown of firefox (and others) rather than simply killing Xorg...
Relevant file is core-agent-linux/misc/dispvm-prerun.sh.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 30 Jun 2014 12:53 UTC
Most likely it will not help. We need clean shutdown of firefox (and others) rather than simply killing Xorg...
Relevant file is core-agent-linux/misc/dispvm-prerun.sh.

@marmarek marmarek added this to the Release 2 milestone Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 30 Jun 2014 14:30 UTC
firefox can be "gracefully killed" via xkill:

xkill -id $(xwininfo -root -children | fgrep '"Navigator"' | awk '{ print $1 }')

but it must be done from inside the VM, xkill from dom0 kills guid

Member

marmarek commented Mar 8, 2015

Comment by woju on 30 Jun 2014 14:30 UTC
firefox can be "gracefully killed" via xkill:

xkill -id $(xwininfo -root -children | fgrep '"Navigator"' | awk '{ print $1 }')

but it must be done from inside the VM, xkill from dom0 kills guid

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 30 Jun 2014 14:31 UTC
That script I've pointed is running inside of VM.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 30 Jun 2014 14:31 UTC
That script I've pointed is running inside of VM.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 30 Jun 2014 14:37 UTC
Hmmm, can we just kill all windows before killall Xorg in core-agent-linux/vm-systemd/prepare-dvm.sh?

Member

marmarek commented Mar 8, 2015

Comment by woju on 30 Jun 2014 14:37 UTC
Hmmm, can we just kill all windows before killall Xorg in core-agent-linux/vm-systemd/prepare-dvm.sh?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 30 Jun 2014 14:41 UTC
Sounds good.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 30 Jun 2014 14:41 UTC
Sounds good.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 4 Jul 2014 13:51 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 4 Jul 2014 13:51 UTC

@marmarek marmarek self-assigned this Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 4 Jul 2014 18:39 UTC
xkill wasn't enough - Firefox still handled that as crash. No surprise - xkill forcefully terminate x11 connection to particular client (XKillClient call).
Done by sending proper WM_DELETE_WINDOW message - same as window manager in response to "close" button of window decoration.
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fd42d99803bd856c977e6fb3db6a4b12612ad6b1

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 4 Jul 2014 18:39 UTC
xkill wasn't enough - Firefox still handled that as crash. No surprise - xkill forcefully terminate x11 connection to particular client (XKillClient call).
Done by sending proper WM_DELETE_WINDOW message - same as window manager in response to "close" button of window decoration.
http://git.qubes-os.org/?p=marmarek/core-agent-linux.git;a=commit;h=fd42d99803bd856c977e6fb3db6a4b12612ad6b1

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment