New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black Theme #911

Closed
marmarek opened this Issue Mar 8, 2015 · 31 comments

Comments

Projects
None yet
5 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by anonymous on 29 Oct 2014 14:20 UTC
I love Qubes-OS! And plan on donating more. Though the current theme is boring & ugly. A sleek looking dark black theme would be great for both the dmo0 and VM templates as a default or at least as a choice. Thanks.

Migrated-From: https://wiki.qubes-os.org/ticket/911

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by cprise@gmail.com on 3 Nov 2014 04:43 UTC
The Wonton Soup color scheme is one that I use. But VM Manager doesn't adjust the meter bars to the darker colors. That would be a good place to start adding support for darker themes.

An option for darker / less saturated window frames would help, too. The regular Qubes frame colors are a bit intense.

Member

marmarek commented Mar 8, 2015

Comment by cprise@gmail.com on 3 Nov 2014 04:43 UTC
The Wonton Soup color scheme is one that I use. But VM Manager doesn't adjust the meter bars to the darker colors. That would be a good place to start adding support for darker themes.

An option for darker / less saturated window frames would help, too. The regular Qubes frame colors are a bit intense.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 3 Nov 2014 20:51 UTC
Woju, AFAIR you had similar problem with dark theme. Did you solve it somehow?

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 3 Nov 2014 20:51 UTC
Woju, AFAIR you had similar problem with dark theme. Did you solve it somehow?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by woju on 4 Nov 2014 16:56 UTC
No, I didn't. I hid the gauges and left enabled only the graphs. Bargraphs look nice on dark background. :)

But yes, we need to rework the widgets. For one, we may use stock widget from qt and ditch the custom one.

Member

marmarek commented Mar 8, 2015

Comment by woju on 4 Nov 2014 16:56 UTC
No, I didn't. I hid the gauges and left enabled only the graphs. Bargraphs look nice on dark background. :)

But yes, we need to rework the widgets. For one, we may use stock widget from qt and ditch the custom one.

@marmarek marmarek added this to the Far in the future milestone Oct 9, 2015

@bnvk

This comment has been minimized.

Show comment
Hide comment
@bnvk

bnvk Nov 24, 2015

I'm definitely in favour of this dark option existing and have kind of configured my KDE to this end at present. I'll take this into account further down the line!

bnvk commented Nov 24, 2015

I'm definitely in favour of this dark option existing and have kind of configured my KDE to this end at present. I'll take this into account further down the line!

@andrewdavidwong andrewdavidwong added the UX label Apr 6, 2016

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 11, 2016

Hello,

I like the dark option too. I have been able to change most of Qubes OS 3.1 KDE 4 to use a dark theme. The only thing I did was playing around with the KDE settings.

The first image shows a Qubes Manager in Black and the Desktop theme is also dark:
qubes-black-3

The menu is dark as well, which works perfectly fine:
qubes-black-2

The only problem with the Qubes Manager are the graphs. The problem is here the text color. The text color of the graphs should always bee black on white background:
qubes-black-4

Only the close, resize and minimize buttons of the Plastik for Qubes theme does not work well together with the Oxygen application window theme:
qubes-black-5

Besides the two minor issues buttons for the black theme and the graphs in the Qubes Manager everything works perfectly fine. Let's see what in KDE 5 with the Breeze theme.

Jeeppler commented May 11, 2016

Hello,

I like the dark option too. I have been able to change most of Qubes OS 3.1 KDE 4 to use a dark theme. The only thing I did was playing around with the KDE settings.

The first image shows a Qubes Manager in Black and the Desktop theme is also dark:
qubes-black-3

The menu is dark as well, which works perfectly fine:
qubes-black-2

The only problem with the Qubes Manager are the graphs. The problem is here the text color. The text color of the graphs should always bee black on white background:
qubes-black-4

Only the close, resize and minimize buttons of the Plastik for Qubes theme does not work well together with the Oxygen application window theme:
qubes-black-5

Besides the two minor issues buttons for the black theme and the graphs in the Qubes Manager everything works perfectly fine. Let's see what in KDE 5 with the Breeze theme.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 11, 2016

Setting the VM's to a black theme requires gnome-tweak-tools to enable the GTK dark theme for gnome:

vm-black

Only Firefox has a problem with the gnome-dark theme and HTML forms. The dark theme makes forms unreadable. This is only a minor issue and requires to overwrite Firefox CSS default stylesheet.

Installing the following plugin: Stylish and in the plugin a GTK dark theme, helps to overwrite the default Firefox CSS, so that everything works correctly.

Jeeppler commented May 11, 2016

Setting the VM's to a black theme requires gnome-tweak-tools to enable the GTK dark theme for gnome:

vm-black

Only Firefox has a problem with the gnome-dark theme and HTML forms. The dark theme makes forms unreadable. This is only a minor issue and requires to overwrite Firefox CSS default stylesheet.

Installing the following plugin: Stylish and in the plugin a GTK dark theme, helps to overwrite the default Firefox CSS, so that everything works correctly.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 11, 2016

Member

I use the same dark themes, too. If you don't want to install Stylish to fix Firefox, you can just add this line to /rw/config/rc.local:

sed -i.bak "s/Exec=firefox %u/Exec=bash -c 'GTK_THEME=Adwaita:light firefox %u'/g" /usr/share/applications/firefox.desktop
Member

andrewdavidwong commented May 11, 2016

I use the same dark themes, too. If you don't want to install Stylish to fix Firefox, you can just add this line to /rw/config/rc.local:

sed -i.bak "s/Exec=firefox %u/Exec=bash -c 'GTK_THEME=Adwaita:light firefox %u'/g" /usr/share/applications/firefox.desktop
@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 28, 2016

So, what should be done to mark this issue as resolved?

So, what should be done to mark this issue as resolved?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 29, 2016

Member

@andrewdavidwong do you think it qualifies for a documentation page?

Member

marmarek commented May 29, 2016

@andrewdavidwong do you think it qualifies for a documentation page?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 30, 2016

Member

Sure, there can be a doc page about this. However, I think the OP had in mind something "built-in":

A sleek looking dark black theme would be great for both the dmo0 and VM templates as a default or at least as a choice.

Member

andrewdavidwong commented May 30, 2016

Sure, there can be a doc page about this. However, I think the OP had in mind something "built-in":

A sleek looking dark black theme would be great for both the dmo0 and VM templates as a default or at least as a choice.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 30, 2016

Member

@Jeeppler, since you've already done a lot of good work on this (incl. screenshots), would you be interested in writing the doc page and submitting it as a PR?

Member

andrewdavidwong commented May 30, 2016

@Jeeppler, since you've already done a lot of good work on this (incl. screenshots), would you be interested in writing the doc page and submitting it as a PR?

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 30, 2016

I mean Qubes Debian and especially Fedora Images could include Gnome-Tweak-Tool, to set GTK Desktops to "GTK Dark Theme". Qubes OS Dom0 could be tested with Light and Dark Theme.

It would be maybe a good idea to let the user choose during the installation process if he want's to have a light or dark theme for Dom0 (+DomU's).

I mean Qubes Debian and especially Fedora Images could include Gnome-Tweak-Tool, to set GTK Desktops to "GTK Dark Theme". Qubes OS Dom0 could be tested with Light and Dark Theme.

It would be maybe a good idea to let the user choose during the installation process if he want's to have a light or dark theme for Dom0 (+DomU's).

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 30, 2016

@andrewdavidwong Yes, I am interested in writing a doc page and submitting it as a PR.

@andrewdavidwong Yes, I am interested in writing a doc page and submitting it as a PR.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 30, 2016

Member

Thank you! :)

Member

andrewdavidwong commented May 30, 2016

Thank you! :)

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jun 9, 2016

Member

@marmarek: Does this issue actually have two parts: doc page and integrated theme option? Or are we closing this after the doc page gets written? (Or splitting into two issues, etc.)

Member

andrewdavidwong commented Jun 9, 2016

@marmarek: Does this issue actually have two parts: doc page and integrated theme option? Or are we closing this after the doc page gets written? (Or splitting into two issues, etc.)

andrewdavidwong added a commit that referenced this issue Jun 12, 2016

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jun 16, 2016

I created a pull request in qubes-doc and qubes-attachment for the documentation.

I created a pull request in qubes-doc and qubes-attachment for the documentation.

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jun 16, 2016

How did I miss this one? I like dark themes.

I'll submit my fix for the CPU/disk meter bars that works with both bright and dark...

domU gnome: Enable dark theme without tweaktool...

mkdir -p .config/gtk-3.0
echo "[Settings]" >.config/gtk-3.0/settings.ini
echo "gtk-application-prefer-dark-theme=1" >>.config/gtk-3.0/settings.ini

You may still have to tell gnome-terminal to 'yes really use the dark theme' in its prefs. But the other apps should conform.

domU KDE: Don't have one yet. I have a couple vms with KDE apps that need it.

Mozilla apps: I've been using a combination of the DeepDark theme and (for Firefox) a page-coloring extension such as "Blank Your Monitor" and "Color Transform". BYM works well with DeepDark if you turn off "Form enhancement" so that location bar, etc. doesn't turn bright. DeepDark on Tbird isn't as thorough so I had to tweak it.

tasket commented Jun 16, 2016

How did I miss this one? I like dark themes.

I'll submit my fix for the CPU/disk meter bars that works with both bright and dark...

domU gnome: Enable dark theme without tweaktool...

mkdir -p .config/gtk-3.0
echo "[Settings]" >.config/gtk-3.0/settings.ini
echo "gtk-application-prefer-dark-theme=1" >>.config/gtk-3.0/settings.ini

You may still have to tell gnome-terminal to 'yes really use the dark theme' in its prefs. But the other apps should conform.

domU KDE: Don't have one yet. I have a couple vms with KDE apps that need it.

Mozilla apps: I've been using a combination of the DeepDark theme and (for Firefox) a page-coloring extension such as "Blank Your Monitor" and "Color Transform". BYM works well with DeepDark if you turn off "Form enhancement" so that location bar, etc. doesn't turn bright. DeepDark on Tbird isn't as thorough so I had to tweak it.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jun 16, 2016

I use Black Dark by rtodorovsky as black theme for Firefox.

domU KDE -> should be the same as for Dom0 KDE.

I use Black Dark by rtodorovsky as black theme for Firefox.

domU KDE -> should be the same as for Dom0 KDE.

andrewdavidwong added a commit that referenced this issue Jun 18, 2016

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 1, 2016

I've entered a simple and good-looking fix for the CPU/mem meters. Just change white to transparent and 0 to 1 where indicated...

@@ -398,11 +398,11 @@ def __init__(self, min, max, format, update_func, vm, load, hue=210, parent = No
                                     "QProgressBar:horizontal{" +\
                                         "border: 1px solid hsv({0}, 100, 250);".format(hue) +\
                                         "border-radius: 4px;\
-                                        background: white;\
+                                        background: transparent;\
                                         text-align: center;\
                                     }\
                                     QProgressBar::chunk:horizontal {\
-                                        background: qlineargradient(x1: 0, y1: 0.5, x2: 1, y2: 0.5, " +\
+                                        background: qlineargradient(x1: 1, y1: 0.5, x2: 1, y2: 0.5, " +\
                                         "stop: 0 hsv({0}, 170, 207),".format(hue) +
                                         " stop: 1 white); \
                                     }"

QubesOS/qubes-manager@master...ttasket:patch-1

snapshot2

tasket commented Jul 1, 2016

I've entered a simple and good-looking fix for the CPU/mem meters. Just change white to transparent and 0 to 1 where indicated...

@@ -398,11 +398,11 @@ def __init__(self, min, max, format, update_func, vm, load, hue=210, parent = No
                                     "QProgressBar:horizontal{" +\
                                         "border: 1px solid hsv({0}, 100, 250);".format(hue) +\
                                         "border-radius: 4px;\
-                                        background: white;\
+                                        background: transparent;\
                                         text-align: center;\
                                     }\
                                     QProgressBar::chunk:horizontal {\
-                                        background: qlineargradient(x1: 0, y1: 0.5, x2: 1, y2: 0.5, " +\
+                                        background: qlineargradient(x1: 1, y1: 0.5, x2: 1, y2: 0.5, " +\
                                         "stop: 0 hsv({0}, 170, 207),".format(hue) +
                                         " stop: 1 white); \
                                     }"

QubesOS/qubes-manager@master...ttasket:patch-1

snapshot2

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 1, 2016

FYI, I didn't show the actual "graphs" along with the "meters" shown above. The graphs also look correct with this fix.

Since KDE5 includes nice dark palettes, it would be nice to have this in the 3.2 release.

tasket commented Jul 1, 2016

FYI, I didn't show the actual "graphs" along with the "meters" shown above. The graphs also look correct with this fix.

Since KDE5 includes nice dark palettes, it would be nice to have this in the 3.2 release.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 2, 2016

Member

Since KDE5 includes nice dark palettes, it would be nice to have this in the 3.2 release.

Would that only work for users who manually install KDE in R3.2? I imagine most users will switch to XFCE, since that'll be the new default.

Member

andrewdavidwong commented Jul 2, 2016

Since KDE5 includes nice dark palettes, it would be nice to have this in the 3.2 release.

Would that only work for users who manually install KDE in R3.2? I imagine most users will switch to XFCE, since that'll be the new default.

andrewdavidwong added a commit that referenced this issue Jul 2, 2016

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 2, 2016

Qubes Manager is a Qt application, so that depends on whether users can control Qt color scheme from XFCE. I think the meter rendering should corrected in either case.

tasket commented Jul 2, 2016

Qubes Manager is a Qt application, so that depends on whether users can control Qt color scheme from XFCE. I think the meter rendering should corrected in either case.

andrewdavidwong added a commit that referenced this issue Jul 2, 2016

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jul 12, 2016

XFCE comes with dark themes by default, but there are not really usable. This is at least my experience when I was testing it on Q R3.1. I think the changes will have a good effect for both desktop environments.

Jeeppler commented Jul 12, 2016

XFCE comes with dark themes by default, but there are not really usable. This is at least my experience when I was testing it on Q R3.1. I think the changes will have a good effect for both desktop environments.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jul 26, 2016

@andrewdavidwong this Qubes Issue should have multiple related issues which can be fixed separately. I would recommend something to split this in documentation: Dom0 (KDE, XCFE dark theme), VM dark theme and development tasks. Otherwise this taks will be here for ever.

Jeeppler commented Jul 26, 2016

@andrewdavidwong this Qubes Issue should have multiple related issues which can be fixed separately. I would recommend something to split this in documentation: Dom0 (KDE, XCFE dark theme), VM dark theme and development tasks. Otherwise this taks will be here for ever.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 26, 2016

Member

@Jeeppler: Yes, I was waiting for an answer from @marmarek to my question above about that.

However, the more I think about it, the less clear it is to me that we need any further issues on this. Thanks to you, we already have extensive documentation on how to implement dark themes in KDE and XFCE in dom0 and in various VMs. The biggest problem is/was the Qubes VM Manager, which is going away soon anyway. So, what is actually left to do? The only possibility that comes to mind is a built-in option for enabling a global dark theme, as I mentioned above, but this would be a significant undertaking. It would have to be a community contribution.

So, as I see it, we're left with two options: call this issue done and close it now, or leave it open as a "help wanted" task for implemented the built-in global dark theme option. @marmarek, what do you think?

Member

andrewdavidwong commented Jul 26, 2016

@Jeeppler: Yes, I was waiting for an answer from @marmarek to my question above about that.

However, the more I think about it, the less clear it is to me that we need any further issues on this. Thanks to you, we already have extensive documentation on how to implement dark themes in KDE and XFCE in dom0 and in various VMs. The biggest problem is/was the Qubes VM Manager, which is going away soon anyway. So, what is actually left to do? The only possibility that comes to mind is a built-in option for enabling a global dark theme, as I mentioned above, but this would be a significant undertaking. It would have to be a community contribution.

So, as I see it, we're left with two options: call this issue done and close it now, or leave it open as a "help wanted" task for implemented the built-in global dark theme option. @marmarek, what do you think?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 26, 2016

Member

I think it is unrealistic to have built-in global option, that would be huge task (involving both dom0 and VMs). So this may be closed.

Member

marmarek commented Jul 26, 2016

I think it is unrealistic to have built-in global option, that would be huge task (involving both dom0 and VMs). So this may be closed.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jul 26, 2016

@marmarek I don't think there is a need to have a built-in global option. The only thing I would like to see is that you select a dark and a bright default theme for XCFE during the development phase of R3.2 and R4. This could be done by community members. You could open another issue for that, like: "R3.2 or R4 XCFE black default theme" and make sure that it is documented how to use/configure the theme. @marmarek, @andrewdavidwong, @bnvk What do you think about that?

@marmarek I don't think there is a need to have a built-in global option. The only thing I would like to see is that you select a dark and a bright default theme for XCFE during the development phase of R3.2 and R4. This could be done by community members. You could open another issue for that, like: "R3.2 or R4 XCFE black default theme" and make sure that it is documented how to use/configure the theme. @marmarek, @andrewdavidwong, @bnvk What do you think about that?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 27, 2016

Member

@Jeeppler: Are you suggesting that a dark theme should be pre-selected as the default when Qubes OS is installed? I'm not so sure that's a good idea. As much as I personally love dark themes, I think we should recognize that many users don't like them, and there's a reason why almost every user-facing default theme is light.

Member

andrewdavidwong commented Jul 27, 2016

@Jeeppler: Are you suggesting that a dark theme should be pre-selected as the default when Qubes OS is installed? I'm not so sure that's a good idea. As much as I personally love dark themes, I think we should recognize that many users don't like them, and there's a reason why almost every user-facing default theme is light.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jul 27, 2016

No, not as default, but for those who want to select a dark theme their should be one installed which works 100% with Qubes OS. One dark theme which is tested and a Qubes OS recommendation.

You are right, light themes are often the default, but if you want to switch to a dark theme it looks horrible and you have to configure a lot of options to make it work. This should not be the case. People who want to switch they should have one working dark theme.

For example right now the Qubes VM Manager looks horrible with dark themes under XCFE.

No, not as default, but for those who want to select a dark theme their should be one installed which works 100% with Qubes OS. One dark theme which is tested and a Qubes OS recommendation.

You are right, light themes are often the default, but if you want to switch to a dark theme it looks horrible and you have to configure a lot of options to make it work. This should not be the case. People who want to switch they should have one working dark theme.

For example right now the Qubes VM Manager looks horrible with dark themes under XCFE.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 27, 2016

Member

Sounds good. I've created #2204 to track that.

Member

andrewdavidwong commented Jul 27, 2016

Sounds good. I've created #2204 to track that.

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler Jul 27, 2016

@andrewdavidwong yes, that is what I meant.

@andrewdavidwong yes, that is what I meant.

andrewdavidwong added a commit that referenced this issue Jul 30, 2016

Untrack #911 (completed)
The documentation task for #911 is complete, but the development task
has been branched into #2204, which is not yet tracked here since no one
has volunteered to take on the task yet.

@tasket tasket referenced this issue in QubesOS/qubes-manager Mar 21, 2017

Merged

Progress bar can match light or dark palette #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment