New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI and UX: colorized app icons in taskbar instead of colorized locks #967

Closed
nvesely opened this Issue Apr 25, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@nvesely

nvesely commented Apr 25, 2015

I'd like if the colorized "app" icons were visible in the taskbar as they are in krunner. Right now, every domU program in the taskbar panel has a colorized lock. This not only looks bad (UI), but changing it would also help users more quickly identify/ remember what is running by not necessarily having to read the text next to it (UX).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Apr 25, 2015

Member

This is actually non trivial feature, because dom0 have no idea what application is running in which window. This would require some additional data passed from VM to the dom0, which means slightly more complicated protocol -> bigger attack surface.
Also some applications do not expose icon name (which can be matched with colorized icon already present in dom0), but only icon bitmap (which need to be processed). Surely we don't want to do the later thing at each window creation.

Member

marmarek commented Apr 25, 2015

This is actually non trivial feature, because dom0 have no idea what application is running in which window. This would require some additional data passed from VM to the dom0, which means slightly more complicated protocol -> bigger attack surface.
Also some applications do not expose icon name (which can be matched with colorized icon already present in dom0), but only icon bitmap (which need to be processed). Surely we don't want to do the later thing at each window creation.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Aug 6, 2015

Member

This is the top usability issue I am struggling with every day.

Member

adrelanos commented Aug 6, 2015

This is the top usability issue I am struggling with every day.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Aug 6, 2015

Member

Yep, really useful feature, I also think the top one in UX category. But releasing working 3.0 (with the current feature set) and Whonix 11 have higher priority...

Member

marmarek commented Aug 6, 2015

Yep, really useful feature, I also think the top one in UX category. But releasing working 3.0 (with the current feature set) and Whonix 11 have higher priority...

@marmarek marmarek added the P: major label Sep 20, 2015

@marmarek marmarek self-assigned this Sep 20, 2015

marmarek added a commit to marmarek/old-qubes-gui-agent-linux that referenced this issue Sep 20, 2015

Implement window icon updater (#967)
It is made as separate service to not introduce further complexity into
gui-daemon code. Also using python is much easier - especially because
we already have icons processing code in python.

This feature consists of two parts:
1. icon-sender is started in the VM from /etc/xdg/autostart, and then
connects to dom0 service qubes.WindowIconUpdater (this commit)
2. icon-receiver - implementation of qubes.WindowIconUpdater service for
dom0

QubesOS/qubes-issues#967

marmarek added a commit to marmarek/old-qubes-gui-daemon that referenced this issue Sep 20, 2015

Implement window icon updater (#967)
It is made as separate service to not introduce further complexity into
gui-daemon code. Also using python is much easier - especially because
we already have icons processing code in python.

This feature consists of two parts:
1. icon-sender is started in the VM from /etc/xdg/autostart, and then
connects to dom0 service qubes.WindowIconUpdater
2. icon-receiver - implementation of qubes.WindowIconUpdater service for
dom0 (this commit)

QubesOS/qubes-issues#967
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 20, 2015

Member

Some preliminary implementation done. Commits linked above (branch icon-updater). Will merge it after final R3.0 release (aka R3.1 merge window).
This will needs some testing, especially for different VM types, minimal template (or Whonix based on it), DispVM etc.

Member

marmarek commented Sep 20, 2015

Some preliminary implementation done. Commits linked above (branch icon-updater). Will merge it after final R3.0 release (aka R3.1 merge window).
This will needs some testing, especially for different VM types, minimal template (or Whonix based on it), DispVM etc.

marmarek added a commit to marmarek/old-qubes-gui-daemon that referenced this issue Sep 29, 2015

Merge branch 'icon-updater'
* icon-updater:
  icon-updater: improve code style, comments, no functional change
  Add R: python-xpyb
  Implement window icon updater (#967)

QubesOS/qubes-issues#967

marmarek added a commit to marmarek/old-qubes-gui-agent-linux that referenced this issue Sep 29, 2015

Merge branch 'icon-updater'
* icon-updater:
  Add python-xpyb dependency for icon-updater
  Implement window icon updater (#967)

QubesOS/qubes-issues#967

@marmarek marmarek closed this Nov 5, 2015

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Mar 19, 2016

Member

What is the status of this? I am on R3.1 testing and still have colored locks rather then colorized app icons.

Member

adrelanos commented Mar 19, 2016

What is the status of this? I am on R3.1 testing and still have colored locks rather then colorized app icons.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 21, 2016

Member

Always? See #1495

Member

marmarek commented Mar 21, 2016

Always? See #1495

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Mar 21, 2016

Member
Member

adrelanos commented Mar 21, 2016

@najamelan

This comment has been minimized.

Show comment
Hide comment
@najamelan

najamelan Dec 28, 2017

This used to work for me on Q4R3, but it seems like this regresses as I switch my vms to fedora-26 template.

This used to work for me on Q4R3, but it seems like this regresses as I switch my vms to fedora-26 template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment