New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong screen resolution (64x64) set for AppVM X server when xrandr unavailable on Dom0 side #998

Closed
plushambush opened this Issue May 14, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@plushambush

When Dom0 start AppVM it set AppVM's X server resolution by asking xrandr for the current screen resolution and passing result to the SetMonitorLayout RPC service on the AppVM side.
But qubes-monitor-layout-notify script which is responsible for this job don't check result returned by xrandr for correct data. As result It send an empty string to the SetMonitorLayout, this empty string is received by xrandr on AppVM side and screen resolution set to minimum (which is 64x64)

Consider using other means of getting screen resolution (xwininfo?) when xrandr is unavailable

Tested on Qubes 3 RC1
Screen setup: 3 heads, 2 video cards (1 on Intel + 2 on Nvidia), Xinerama is on

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 14, 2015

Member

Can you paste here output of xrandr in dom0 in such case?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented May 14, 2015

Can you paste here output of xrandr in dom0 in such case?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@plushambush

This comment has been minimized.

Show comment
Hide comment
@plushambush

plushambush May 15, 2015

Seems that it's not needed anymore, but as you asked

[ricochet@dom0 Desktop]$ xrandr -q
RandR extension missing

Seems that it's not needed anymore, but as you asked

[ricochet@dom0 Desktop]$ xrandr -q
RandR extension missing
@plushambush

This comment has been minimized.

Show comment
Hide comment
@plushambush

plushambush May 15, 2015

But this patch marmarek/qubes-gui-daemon@7bb67ac will just make watch-screen-layout-changes ignore all further layout changes and it become completely useless.

But this patch marmarek/qubes-gui-daemon@7bb67ac will just make watch-screen-layout-changes ignore all further layout changes and it become completely useless.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 15, 2015

Member

Yes, if xrandr does not report screen dimensions it is pointless
forwarding xrandr events to the VM. I think in such a case,
qubes-monitor-layout-notify will not be called at all in the first
place.
If you want some other screen size notification method, feel free to
provide a more details, or - preferably - a patch.

Without this mechanism, VM still know the full screen size - it is sent
by gui-daemon at the VM startup.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented May 15, 2015

Yes, if xrandr does not report screen dimensions it is pointless
forwarding xrandr events to the VM. I think in such a case,
qubes-monitor-layout-notify will not be called at all in the first
place.
If you want some other screen size notification method, feel free to
provide a more details, or - preferably - a patch.

Without this mechanism, VM still know the full screen size - it is sent
by gui-daemon at the VM startup.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

plushambush added a commit to plushambush/qubes-core-admin that referenced this issue Oct 9, 2015

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Oct 11, 2015

Merge remote-tracking branch 'qubesos/pr/7'
* qubesos/pr/7:
  Don't send screen layout to the VM if we haven't received it from xrandr because this breaks proper initial screen layout set by gui-agent Fixes QubesOS/qubes-issues#1305 QubesOS/qubes-issues#998

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Oct 11, 2015

Don't send screen layout to the VM if we haven't received it from xrandr
because this breaks proper initial screen layout set by gui-agent
Fixes QubesOS/qubes-issues#1305 QubesOS/qubes-issues#998

(cherry picked from commit 78c3f40)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment