Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
I implemented new tool for qucs. It is QucsActiveFilter. This tool allows to design active Butterworth, Chebyshev, Cauer, Bessel and User defined active filters. Sallen-Key, Multifeedback and Cauer topologies are implemented. I hope, it will be usefull.
Added new subdirectory qucs/qucsactivefilter, that contains all of my new sourcecode.
If you will merge this pull request, add directory entry qucs/qucsactivefilter to main CMakeLists, please.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Hello! Thank you very much for this contribution. It looks great and very useful!
I haven't build the code yet but allow me a few suggestions anyway:
Before we merge into master let us make sure it is integrated on both build systems and that it builds ok on a few different environments.
Mail to this list is posted.
I have no experience with Autotools. As I can understand, I need to add my new su
Recent added. See new commits in my branch.
This fix added to my CMakeLists
Yes, it was old project name. It is fully removed. See last commits.
It bulds ok on Linux x86-64 and Windows32bit with MinGW. Not tested for MacOS, beacause I have no available Macs near me.
I will test on the MacOS and report back.
I did some testing on OSX 10.6 (will test again for 10.9), and so far it seems fine.
A few more considerations:
Instead of issuing a message like:
You could disable the Cauer option if the Chebyshev or Butterworth are selected, so users know in advance what can be done. My suggestion is to make it more intuitive.