Activefilt #13

Closed
wants to merge 96 commits into
from

Conversation

Projects
None yet
2 participants
@ra3xdh
Contributor

ra3xdh commented Jul 10, 2014

Dear friends!

I implemented new tool for qucs. It is QucsActiveFilter. This tool allows to design active Butterworth, Chebyshev, Cauer, Bessel and User defined active filters. Sallen-Key, Multifeedback and Cauer topologies are implemented. I hope, it will be usefull.

Added new subdirectory qucs/qucsactivefilter, that contains all of my new sourcecode.

If you will merge this pull request, add directory entry qucs/qucsactivefilter to main CMakeLists, please.

qucsactivefilter

qucsactivefilter1

ra3xdh added some commits Apr 10, 2014

Filter schematic elements calculation methods moved to Filter class c…
…ompletely. Started filter schematic Qucs file generating implementation

ra3xdh added some commits May 15, 2014

Order determination for user defined transfer function fixed. Sparce …
…transfer function polynomials functionality removed
@guitorri

This comment has been minimized.

Show comment Hide comment
@guitorri

guitorri Jul 10, 2014

Member

Hello! Thank you very much for this contribution. It looks great and very useful!

I haven't build the code yet but allow me a few suggestions anyway:

  • please post/advertise also to qucs-devel mailing list. Not all developers are active on this GitHub mirror.
  • we need to add support for Autotools (the "official" build system) besides CMake. If you are not familiar with Autotools I can assist you on this.
  • not all your files have the GPL header, please add them
  • the version on <Qucs Schematic 0.0.17> should come from the config.h (recently fixed on master b71c224)
  • QFilterSintez became QucsActiveFilter? The original name is still around in a few places.

Before we merge into master let us make sure it is integrated on both build systems and that it builds ok on a few different environments.

Member

guitorri commented Jul 10, 2014

Hello! Thank you very much for this contribution. It looks great and very useful!

I haven't build the code yet but allow me a few suggestions anyway:

  • please post/advertise also to qucs-devel mailing list. Not all developers are active on this GitHub mirror.
  • we need to add support for Autotools (the "official" build system) besides CMake. If you are not familiar with Autotools I can assist you on this.
  • not all your files have the GPL header, please add them
  • the version on <Qucs Schematic 0.0.17> should come from the config.h (recently fixed on master b71c224)
  • QFilterSintez became QucsActiveFilter? The original name is still around in a few places.

Before we merge into master let us make sure it is integrated on both build systems and that it builds ok on a few different environments.

@ra3xdh

This comment has been minimized.

Show comment Hide comment
@ra3xdh

ra3xdh Jul 11, 2014

Contributor

Hello, Guilherme!

please post/advertise also to qucs-devel mailing list.
Not all developers are active on this GitHub mirror.

Mail to this list is posted.

we need to add support for Autotools (the "official" build system) besides CMake.
If you are not familiar with Autotools I can assist you on this.

I have no experience with Autotools. As I can understand, I need to add my new su
bdirectory to qucs/Makefile.am? Please help me with this task.

not all your files have the GPL header, please add them

Recent added. See new commits in my branch.

the version on should come from the config.h (recently fixed on master b71c224)

This fix added to my CMakeLists

QFilterSintez became QucsActiveFilter? The original name is still around in a few places.

Yes, it was old project name. It is fully removed. See last commits.

Before we merge into master let us make sure it is integrated on both build systems and that it >builds ok on a few different environments.

It bulds ok on Linux x86-64 and Windows32bit with MinGW. Not tested for MacOS, beacause I have no available Macs near me.

Contributor

ra3xdh commented Jul 11, 2014

Hello, Guilherme!

please post/advertise also to qucs-devel mailing list.
Not all developers are active on this GitHub mirror.

Mail to this list is posted.

we need to add support for Autotools (the "official" build system) besides CMake.
If you are not familiar with Autotools I can assist you on this.

I have no experience with Autotools. As I can understand, I need to add my new su
bdirectory to qucs/Makefile.am? Please help me with this task.

not all your files have the GPL header, please add them

Recent added. See new commits in my branch.

the version on should come from the config.h (recently fixed on master b71c224)

This fix added to my CMakeLists

QFilterSintez became QucsActiveFilter? The original name is still around in a few places.

Yes, it was old project name. It is fully removed. See last commits.

Before we merge into master let us make sure it is integrated on both build systems and that it >builds ok on a few different environments.

It bulds ok on Linux x86-64 and Windows32bit with MinGW. Not tested for MacOS, beacause I have no available Macs near me.

@ra3xdh

This comment has been minimized.

Show comment Hide comment
@ra3xdh

ra3xdh Jul 11, 2014

Contributor

we need to add support for Autotools (the "official" build system) besides CMake.
If you are not familiar with Autotools I can assist you on this.

I understood how to do this! Added Makefile.am in last commit. All bulds OK with Autotools.

Contributor

ra3xdh commented Jul 11, 2014

we need to add support for Autotools (the "official" build system) besides CMake.
If you are not familiar with Autotools I can assist you on this.

I understood how to do this! Added Makefile.am in last commit. All bulds OK with Autotools.

@guitorri

This comment has been minimized.

Show comment Hide comment
@guitorri

guitorri Jul 15, 2014

Member

I will test on the MacOS and report back.
I saw your post on the Tickets > Patches of SourceForge. The qucs-devel mailing list receives more attention from other developers (https://sourceforge.net/p/qucs/mailman/). I recommend you to subscribe and post also there.

Member

guitorri commented Jul 15, 2014

I will test on the MacOS and report back.
I saw your post on the Tickets > Patches of SourceForge. The qucs-devel mailing list receives more attention from other developers (https://sourceforge.net/p/qucs/mailman/). I recommend you to subscribe and post also there.

@guitorri

This comment has been minimized.

Show comment Hide comment
@guitorri

guitorri Jul 15, 2014

Member

@ra3xdh
I pushed your code (and a few changes I did) to the branch https://github.com/Qucs/qucs/tree/ra3xdh-activefilter. Please let us continue working based on that branch.

I did some testing on OSX 10.6 (will test again for 10.9), and so far it seems fine.

A few more considerations:

  1. Can you put all the images into a bitmap directory similar to the other qucs-tools?

  2. Perhaps in the qucsactivefilter.cpp, some of the errorMessage could be removed:

Instead of issuing a message like:

errorMessage(tr("Unable to use Cauer section for Chebyshev or Butterworth \n"

You could disable the Cauer option if the Chebyshev or Butterworth are selected, so users know in advance what can be done. My suggestion is to make it more intuitive.

  1. a few QGroupBox could help to separate the related items on the interface (see qucsattenuator, qucstrans)

  2. You probably saw the qucs-doc directory. Would you like to write a user manual to your qucsactivefilter? Maybe include a few references and examples... Just an idea.

Member

guitorri commented Jul 15, 2014

@ra3xdh
I pushed your code (and a few changes I did) to the branch https://github.com/Qucs/qucs/tree/ra3xdh-activefilter. Please let us continue working based on that branch.

I did some testing on OSX 10.6 (will test again for 10.9), and so far it seems fine.

A few more considerations:

  1. Can you put all the images into a bitmap directory similar to the other qucs-tools?

  2. Perhaps in the qucsactivefilter.cpp, some of the errorMessage could be removed:

Instead of issuing a message like:

errorMessage(tr("Unable to use Cauer section for Chebyshev or Butterworth \n"

You could disable the Cauer option if the Chebyshev or Butterworth are selected, so users know in advance what can be done. My suggestion is to make it more intuitive.

  1. a few QGroupBox could help to separate the related items on the interface (see qucsattenuator, qucstrans)

  2. You probably saw the qucs-doc directory. Would you like to write a user manual to your qucsactivefilter? Maybe include a few references and examples... Just an idea.

@ra3xdh

This comment has been minimized.

Show comment Hide comment
@ra3xdh

ra3xdh Jul 16, 2014

Contributor

Changes, that you suggest, pushed to branch ra3xdh-activefilter at my fork of Qucs. Pull request to new branch ra3xdh-activefilter is done. See #14 for details.

Contributor

ra3xdh commented Jul 16, 2014

Changes, that you suggest, pushed to branch ra3xdh-activefilter at my fork of Qucs. Pull request to new branch ra3xdh-activefilter is done. See #14 for details.

@guitorri

This comment has been minimized.

Show comment Hide comment
@guitorri

guitorri Jul 21, 2014

Member

Changed to #13

Member

guitorri commented Jul 21, 2014

Changed to #13

@guitorri guitorri closed this Jul 21, 2014

@ra3xdh ra3xdh deleted the ra3xdh:activefilt branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment