I made some changes according the last comment at PullRequest#13 and I would like to merge it into branch ra3xdh-activefilter. Changes are:
Here is screenshot of new interface with QGroupBoxes.
All pictures moved to ./bitmaps
Implemented removing Cauer from Filter Topology QComboBox when Butter…
…worth/Chebyshev/Bessel function is selected
Added QGroupBox'es to main window
Qucsactivefilter interface optimised for laptops
Magic numbers replaced by Enums and removed debug printing
Added helpdialog and MenuBar similar to other Qucs-Tools
I have added Help dialog and Main Menu bar similar to other Qucs-Tools. See last commit.
There is an issue with your last commit:
I guess you have to add helpdialog.cpp to the qucsactivefilter_SOURCES on the Makefile.am.
Added helpdialog.h and helpdialog.cpp to Makefile.am
Issue is fixed. helpdialog.h and helpdialog.cpp are now added to Makefile.am. Travis CI builds OK.
Should we rename the tool to QucsActiveFilter?
./qucsactivefilter.cpp:54: QAction * helpAbout = new QAction(tr("&About QucsFilter..."), this);
./qucsactivefilter.cpp:533: "QucsFilter Version " PACKAGE_VERSION+
What about band-pass and band-stop are these supported/implemented ?
Yes, it should be renamed. This issue is fixed by myself. See #16 for details.
Band stop and band pass filters are not implemented yet. There are only stubs for them. QucsActiveFilter shows warning when user tries to calculate these filters.
I had no time for this in June, because I had been receiving PhD degree in June. I am busy preparing articles for conferences now. I think to begin these functions implementation in September or October.
While this functions is not implemented, I can remove BandPass and BandStop from the cbxResponse QComboBox in the main window. Should I do it now?
Will you have the time to continue implementing the missing filters?
Yes, I will continue BandPass/BandStop filters implementation this month.