Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoardAra (tictactoe, connect four, othello, clobber, breakthrough) #187

Merged
merged 89 commits into from
Oct 23, 2022

Conversation

chooga
Copy link
Contributor

@chooga chooga commented Oct 20, 2022

Thank you for contributing to the CrazyAra repository.

Please shortly describe what you changed in the code.
implemented and tested different board game environments (tictactoe, connect four, othello, clobber, breakthrough)

Before submitting this PR, please make sure:

  • You have read the first steps section in the programmer's guide
  • You are using approved terminology
  • You have pulled the latest updates from the main repository.

chooga and others added 30 commits February 18, 2022 14:18
Update chooga/CrazyAra to the newest CrazyAra Version
Update NB_SQUARES_HORIZONTAL() NB_SQUARES_VERTICAL()
Update NB_LABELS()
@chooga
Copy link
Contributor Author

chooga commented Oct 20, 2022

changes done before merging, maybe following changes need to be reverted in order to start BoardAra again.

  • engine/src/uci/optionsuci.cpp: L.:204 Max and MeanInitPly were set to 0,0,99999 in BoardAra
  • engine/src/rl/rl_training.py: L.:112 local import statement reverted; net.eval() wasn't used in BoardAra
  • engine/src/rl/Dockerfile: L.:28 a different image was used (FROM nvcr.io/nvidia/mxnet:20.10-py3)
  • DeepCrazyhouse/config/rl_config.py: L.:19 binary_name reverted
    L.:30 uci_variant can be set to tictactoe, cfour, clobber, flipersi, or breakthrough for BoardAra

@QueensGambit
Copy link
Owner

Hi @chooga , thanks for the PR.
It looks like the tests are failing due to read_string_from_file().

@QueensGambit
Copy link
Owner

We should probably also add some tests for MODE_BOARDGAME to ensure you can still build it and it won't break.

Update openspielstate.cpp, fairyinputrepresentation.cpp, tensorrtapi.cpp, tensorrtapi.h, fileio.py, optionsuci.cpp, variants.h, variants.ini, .gitmodules, generate_random_nn.py
@QueensGambit
Copy link
Owner

QueensGambit commented Oct 21, 2022

Added unit test in 17f25c2.

@QueensGambit QueensGambit merged commit a0f1c74 into QueensGambit:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants