diff --git a/.changeset/late-tools-grow.md b/.changeset/late-tools-grow.md new file mode 100644 index 00000000..cb8daf20 --- /dev/null +++ b/.changeset/late-tools-grow.md @@ -0,0 +1,5 @@ +--- +'@lightmill/react-experiment': major +--- + +Do not flush before completing a run, and do not require loggers to define a flush method. diff --git a/packages/react-experiment/src/timeline.ts b/packages/react-experiment/src/timeline.ts index e56f22b8..ca9f58a8 100644 --- a/packages/react-experiment/src/timeline.ts +++ b/packages/react-experiment/src/timeline.ts @@ -31,7 +31,6 @@ type TimelineAction = export type Logger = { startRun(): Promise; addLog(log: RegisteredLog): Promise; - flush(): Promise; completeRun(): Promise; cancelRun?(): Promise; }; @@ -117,7 +116,6 @@ export default function useManagedTimeline( }); if (hasEnded) return; dispatch({ type: 'all-tasks-completed' }); - await logger?.flush(); await logger?.completeRun(); if (hasEnded) return; dispatch({ type: 'run-completed' });