From 83b8b0c5bef1ef7a2a7de50b46a10f5ec255df82 Mon Sep 17 00:00:00 2001 From: Quentin Roy Date: Fri, 19 May 2023 15:34:04 +0200 Subject: [PATCH 1/2] react-experiment: do not depend on logger's flush --- packages/react-experiment/src/timeline.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/react-experiment/src/timeline.ts b/packages/react-experiment/src/timeline.ts index e56f22b8..ca9f58a8 100644 --- a/packages/react-experiment/src/timeline.ts +++ b/packages/react-experiment/src/timeline.ts @@ -31,7 +31,6 @@ type TimelineAction = export type Logger = { startRun(): Promise; addLog(log: RegisteredLog): Promise; - flush(): Promise; completeRun(): Promise; cancelRun?(): Promise; }; @@ -117,7 +116,6 @@ export default function useManagedTimeline( }); if (hasEnded) return; dispatch({ type: 'all-tasks-completed' }); - await logger?.flush(); await logger?.completeRun(); if (hasEnded) return; dispatch({ type: 'run-completed' }); From 9c8db5ef99dd1663f144904a83b662227b5e32ba Mon Sep 17 00:00:00 2001 From: Quentin Roy Date: Fri, 19 May 2023 15:41:06 +0200 Subject: [PATCH 2/2] changeset --- .changeset/late-tools-grow.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/late-tools-grow.md diff --git a/.changeset/late-tools-grow.md b/.changeset/late-tools-grow.md new file mode 100644 index 00000000..cb8daf20 --- /dev/null +++ b/.changeset/late-tools-grow.md @@ -0,0 +1,5 @@ +--- +'@lightmill/react-experiment': major +--- + +Do not flush before completing a run, and do not require loggers to define a flush method.