Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwiftPM] Update Package.swift to support Swift 5 #843

Merged
merged 2 commits into from Mar 29, 2019
Merged

Conversation

@devxoul
Copy link
Contributor

devxoul commented Mar 29, 2019

As upgrading to Swift 5, without having platforms the default deployment target is set to the latest version of each OS. It causes a compile error.

  • Add platforms
  • Add .v5 to swiftLanguageVersions
@ikesyo

This comment has been minimized.

Copy link
Member

ikesyo commented Mar 29, 2019

Thanks for the PR, though this breaks backward compatibility.

Package@swift-4.2.swift Show resolved Hide resolved
Package@swift-4.2.swift Show resolved Hide resolved
Package@swift-4.2.swift Show resolved Hide resolved
Package@swift-4.2.swift Show resolved Hide resolved
Package@swift-4.2.swift Show resolved Hide resolved
@ikesyo ikesyo force-pushed the devxoul:swift-5 branch from 7bfa7a0 to 98b15d6 Mar 29, 2019
@ikesyo
ikesyo approved these changes Mar 29, 2019
Copy link
Member

ikesyo left a comment

I fixed the backward compatibility, so this should be good to go now.

@ikesyo

This comment has been minimized.

Copy link
Member

ikesyo commented Mar 29, 2019

Ref: SE-0236

@ikesyo

This comment has been minimized.

Copy link
Member

ikesyo commented Mar 29, 2019

I'll merge this once CI passes.

@ikesyo ikesyo changed the title Update Package.swift to support Swift 5 [SwiftPM] Update Package.swift to support Swift 5 Mar 29, 2019
@ikesyo ikesyo merged commit 692e5f5 into Quick:master Mar 29, 2019
2 checks passed
2 checks passed
Hound 5 violations found.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devxoul devxoul deleted the devxoul:swift-5 branch Mar 31, 2019
@devxoul devxoul restored the devxoul:swift-5 branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.