Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[SwiftPM] Update Package.swift to support Swift 5 #843
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR, though this breaks backward compatibility. |
|
I fixed the backward compatibility, so this should be good to go now. |
This comment has been minimized.
This comment has been minimized.
|
Ref: SE-0236 |
This comment has been minimized.
This comment has been minimized.
|
I'll merge this once CI passes. |
ikesyo
changed the title
ikesyo
merged commit 692e5f5
into
Quick:master
2 checks passed
2 checks passed
Hound
5 violations found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
devxoul commentedMar 29, 2019
As upgrading to Swift 5, without having
platformsthe default deployment target is set to the latest version of each OS. It causes a compile error.platforms.v5toswiftLanguageVersions