Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Behavior<Context> #905

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@VojtaStavik
Copy link
Contributor

@VojtaStavik VojtaStavik commented Jul 22, 2019

I use Quick for several years and recently I accidentally discovered Behavior. I really love the feature! I realized that I didn't know about it because it's not mentioned anywhere in the documentation.

This PR adds another option to the Reducing Test Boilerplate documentation presenting an alternative solution using Behavior<Context>.

@QuickBot
Copy link

@QuickBot QuickBot commented Jul 22, 2019

2 Warnings
⚠️ Need to add an unit test if you’re modifying swift source
⚠️ Big PR

Generated by 🚫 Danger

Loading

@@ -29,7 +29,7 @@ testing, consider reading them in the order they're introduced below:
Read this to learn more about testing code that uses the AppKit and UIKit frameworks.
- **[Testing with test doubles](TestUsingTestDoubles.md)**:
Read this to learn what test doubles are and how to use them.
- **[Reducing Test Boilerplate with Shared Assertions](SharedExamples.md)**:
- **[Reducing Test Boilerplate with Behaviors and Shared Assertions](SharedExamples.md)**:
Copy link
Member

@ikesyo ikesyo Sep 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can define "Shared Assertions" as a concept including both Behavior and sharedExample implementation, so I'd like to leave this as is.

Loading

ikesyo
ikesyo approved these changes Sep 14, 2019
@ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 14, 2019

Thanks for the documentation improvement!

Loading

@ikesyo ikesyo merged commit 757721d into Quick:master Sep 14, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants