Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name variable of Behavior open #906

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@VojtaStavik
Copy link
Contributor

@VojtaStavik VojtaStavik commented Jul 22, 2019

The PR is a byproduct of my article about using Behavior in Quick.

I believe the name variable of Behavior should be open so it's possible to override it and provide custom name, if needed.

@QuickBot
Copy link

@QuickBot QuickBot commented Jul 22, 2019

1 Warning
⚠️ Need to add an unit test if you’re modifying swift source

Generated by 🚫 Danger

Loading

ikesyo
ikesyo approved these changes Sep 7, 2019
Copy link
Member

@ikesyo ikesyo left a comment

LGTM, thanks for the PR 👍

Loading

/**
Override this variable if you want to provide custom name for this example group.
*/
open class var name: String { return String(describing: self) }
Copy link
Member

@ikesyo ikesyo Sep 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I thought before and is not a breaking change, so it's safe to merge.

#821 (comment)

Loading

@ikesyo ikesyo merged commit 6bcaa39 into Quick:master Sep 7, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants