Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postcss for better handling of css transformation #29

Merged

Conversation

Projects
None yet
3 participants
@nvanselow
Copy link
Collaborator

commented Feb 9, 2019

A rethinking of the plugin that uses postcss to better handle the css transformation required to add the css namespacing.

Additionally, all the dependencies have been updated to latest.

I set the version to 1.0.0-rc so people can try this out and we can fix issue before an official 1.0.0 release.

I believe this version of the plugin takes care of all the issues that were reported on the previous version.

Closes #18
Closes #21
Closes #22
Closes #24
Closes #25
Closes #27

nvanselow added some commits Jan 21, 2019

@nvanselow nvanselow requested review from harrismd and mattschweers as code owners Feb 9, 2019

(rawValueWithoutWhiteSpace === '' ||
rawValueWithoutWhiteSpace.endsWith('{') ||
rawValueWithoutWhiteSpace.endsWith('}') ||
rawValueWithoutWhiteSpace.endsWith(';')) &&

This comment has been minimized.

Copy link
@nvanselow

nvanselow Feb 9, 2019

Author Collaborator

I don't love this, but I haven't found a better way to detect when an expression appears on its own line and causes invalid css.

This comment has been minimized.

Copy link
@TrevorBurnham

This comment has been minimized.

Copy link
@nvanselow

nvanselow Mar 14, 2019

Author Collaborator

Awesome. Thanks for the heads up. That might solve another issue that was opened as well.

@Pczek

This comment has been minimized.

Copy link

commented Feb 22, 2019

Would love to test this PR if it fixes my issue. It's not yet released as a RC right?

@nvanselow

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 22, 2019

@Pczek Not yet. I may go ahead and merge and release it as an rc though so people can test.

@nvanselow nvanselow merged commit 5165050 into master Feb 22, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@nvanselow nvanselow deleted the Use_postcss_for_better_handling_of_css_transformation branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.