From d5357ed2cadf7a725d3163da95bf24c76e9fe6ce Mon Sep 17 00:00:00 2001 From: Paul Kraft Date: Fri, 25 Jan 2019 17:36:10 +0100 Subject: [PATCH 1/2] Fix PageCoordinator memory leaks by introducing PageTransition.initial(pages:) --- XCoordinator/Classes/PageCoordinator.swift | 2 +- XCoordinator/Classes/PageTransition.swift | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/XCoordinator/Classes/PageCoordinator.swift b/XCoordinator/Classes/PageCoordinator.swift index 74bbcb39..6b54b4ef 100644 --- a/XCoordinator/Classes/PageCoordinator.swift +++ b/XCoordinator/Classes/PageCoordinator.swift @@ -29,7 +29,7 @@ open class PageCoordinator: BaseCoordinator Transition { + return Transition(presentables: pages, animation: nil) { _, performer, completion in + CATransaction.begin() + CATransaction.setCompletionBlock { + pages.forEach { $0.presented(from: performer) } + completion?() + } + CATransaction.commit() + } + } } From 4a580fe592a8985f236e83a913561dd27ec94ae4 Mon Sep 17 00:00:00 2001 From: Paul Kraft Date: Sat, 26 Jan 2019 23:14:26 +0100 Subject: [PATCH 2/2] Update pod version to 1.2.4 --- XCoordinator.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/XCoordinator.podspec b/XCoordinator.podspec index ddc520f3..c82627c3 100644 --- a/XCoordinator.podspec +++ b/XCoordinator.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |spec| spec.name = 'XCoordinator' - spec.version = '1.2.3' + spec.version = '1.2.4' spec.license = { :type => 'MIT' } spec.homepage = 'https://github.com/quickbirdstudios/XCoordinator' spec.authors = { 'Stefan Kofler' => 'stefan.kofler@quickbirdstudios.com', 'Paul Kraft' => 'pauljohannes.kraft@quickbirdstudios.com' }