Skip to content

Conversation

@dimaspirit
Copy link
Contributor

@dimaspirit dimaspirit commented Jan 10, 2018

Make sure that you wrote the tests for your proposed changes and the existing test was success.

Made/Proposed changes:

  • Check out header QB-SDK for API requests;
  • Fix for Fetch if a response is empty body;
  • Fixes 'contentType' in data module;
  • Updated QB.chat.message.unreadCount() method;
  • Updated QB.chat.dialog.create() method;
  • Updated QB.users.listUsers() method;
  • Fixes for chat sample (QBWEBSDK-616, QBWEBSDK-620, QBWEBSDK-539, QBWEBSDK-624, QBWEBSDK-625, QBWEBSDK-626, QBWEBSDK-627);
  • Fixes for data sample (QBWEBSDK-618, QBWEBSDK-586, QBWEBSDK-594);
  • Fixes for webrtc sample (QBWEBSDK-367, QBWEBSDK-181);

How should this be manually tested?

Does the documentation need an update?

dimaspirit and others added 13 commits November 10, 2017 18:43
Added fetch API instead $.ajax() and request() (REST API support for NativeScript);
The MessageProxy and the DialogProxy were remove from qbChat.js to separate modules.
Chat Module adapted for NativeScript
Note:

In Jasmine tests added 2 pending specs (qbAddressbook):
'Get all existed contacts';
'Get contacts in specific address book / with UDID'.
* fixed for create data - add contentType
* QBWEBSDK-618
* QBWEBSDK-586
* QBWEBSDK-594
The Chat Sample (fixed):
QBWEBSDK-616;
QBWEBSDK-620;
QBWEBSDK-539.

The JS SDK (fixed):
Updated QB.chat.message.unreadCount() method;
Updated QB.chat.dialog.create() method;
Updated QB.users.listUsers() method.
@dimaspirit dimaspirit self-assigned this Jan 19, 2018
@dimaspirit dimaspirit requested a review from soulfly January 29, 2018 13:32
@Vladlukhanin Vladlukhanin merged commit 7c18b84 into gh-pages Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants