New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime change to Time #1

Closed
rwojnarowski opened this Issue May 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@rwojnarowski

rwojnarowski commented May 23, 2018

Apply Rubocop fixes - I think that this change caused some regression. I can't return campaign list. See the screenshot below:

console

@Quintasan Quintasan self-assigned this May 28, 2018

@Quintasan

This comment has been minimized.

Owner

Quintasan commented May 28, 2018

@rwojnarowski Sorry for the late response. It appears that DateTime in Ruby works incorrectly as far as ISO8601 is concerned. Combined date and time in UTC would be 2018-05-06T12:53:22+00:00. What I get from Woodpecker's API is 2018-05-17T12:17:11+0200 (note the missing colon in time zone).

The fact that this was working using DateTime is a bug in Ruby itself. I can either patch the library to use #parse or see if we can have the API return a proper ISO8601 string.

EDIT: Actually scratch that, it's a bug in Time - https://bugs.ruby-lang.org/issues/14790

@Quintasan

This comment has been minimized.

Owner

Quintasan commented May 28, 2018

@rwojnarowski Fixed in v0.1.4. Please check it out and reopen this issue if this still happens.

@Quintasan Quintasan closed this May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment