replaced JsonParser with JsonConvert to allow parsing custom types #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests failed after this commit. Changed parser back . |
|
After half a year lol, but what unit test(s) failed? |
|
THIS PROJECT IS DEPRECATED |
|
That doesnt explain the unit test failure though, and yes, i already read that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this library to make a chat app today, but the parsed result which then gets sent to the webserver differs from other socket io clients for other languages.
Thats why I replaced the arg parser with JsonConvert. The additional benefit is that it can parse any type you give it with ease.