New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenMapTiles 3.9 release #16

Merged
merged 73 commits into from Dec 17, 2018

Conversation

Projects
None yet
@nlehuby
Copy link

nlehuby commented Dec 7, 2018

amatissart and others added some commits Nov 27, 2017

update doc
to add religion as subclass on poi layer
Add a few missing POIs (openmaptiles#391)
* Add a few missing POIs

* hackerspace
* escape room
* subway and station entrance
* frozen food (shop)
Fix import-osm link
the old link was still pointing to Osm2pgsql
Remove borders of leased areas
Fix openmaptiles#416. Affects Baykonur and Guantanamo.

@nlehuby nlehuby changed the title Upgrade to OpenMapTiles 3.9 release WIP - Upgrade to OpenMapTiles 3.9 release Dec 7, 2018

@nlehuby nlehuby force-pushed the merge_3_9 branch from 60d7719 to 27452d4 Dec 7, 2018

@amatissart
Copy link
Member

amatissart left a comment

Besides merge issues, there are also some differences that are due to an older version of openmaptiles-tools. (Please use the latest version, 0.9.2)

Show resolved Hide resolved docker-compose.yml
Show resolved Hide resolved layers/building/building.sql Outdated
Show resolved Hide resolved layers/poi/poi.yaml Outdated

@nlehuby nlehuby force-pushed the merge_3_9 branch from 27452d4 to 5f41aca Dec 11, 2018

@nlehuby

This comment has been minimized.

Copy link

nlehuby commented Dec 11, 2018

Add performances optimizations:

  • remove all tags in poi tiles
  • remove ~40 unused languages (but add French missing ones)
  • remove layers not used in style

@nlehuby nlehuby changed the title WIP - Upgrade to OpenMapTiles 3.9 release Upgrade to OpenMapTiles 3.9 release Dec 12, 2018

@@ -36,9 +36,14 @@ RETURNS TABLE(osm_id bigint, global_id text, geometry geometry, name text, name_
THEN NULLIF(information, '')
WHEN subclass = 'place_of_worship'
THEN NULLIF(religion, '')
WHEN subclass = 'pitch'
THEN NULLIF(sport, '')

This comment has been minimized.

@amatissart

amatissart Dec 12, 2018

Member

These subclass rules are hidden in the tile query, and can't be retrieved by Fafnir. (And as a consequence icons used on the map will not match with UI).
Should we define a new function poi_subclass, similar to poi_class ? (Not so convincing: the signature of this function would change when new tags are used...).

As far as i can see, this is the only remaining problem (but not directly related to this PR).

@nlehuby

This comment has been minimized.

Copy link

nlehuby commented Dec 13, 2018

Here are a few screenshots:
layer park with a name:
capture_park_name

some pier:
man_made pier

some aquarium:
capture du 2018-12-13 11-26-04

a street with a name:fr (they only had name:en and name:de before):
capture_name_streets

some POI with an indoor tag (level) and no tags:
capture_poi_indoor

a pitch with a sport subclass:
capture_sports

@amatissart amatissart merged commit 2882b3e into master Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@nlehuby nlehuby deleted the merge_3_9 branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment