Skip to content

fix(core): wait for streamed container state before events#8689

Merged
wmertens merged 1 commit into
build/v2from
v2-streaming-fix
Jun 5, 2026
Merged

fix(core): wait for streamed container state before events#8689
wmertens merged 1 commit into
build/v2from
v2-streaming-fix

Conversation

@Varixo

@Varixo Varixo commented May 31, 2026

Copy link
Copy Markdown
Member

Fixes a streaming resume race where Qwikloader could run event handlers before the container state script had fully streamed.

Changes:

  • Adds a compact _qwikEv container-ready marker.
  • Gates QRL handler execution during document loading until container state is ready.
  • Covers chunked click handlers while streaming.
  • Guards unsupported symbol serialization from producing malformed JSON.

@Varixo Varixo self-assigned this May 31, 2026
@Varixo Varixo added the V2 label May 31, 2026
@Varixo Varixo requested a review from a team as a code owner May 31, 2026 13:26
@changeset-bot

changeset-bot Bot commented May 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a8509c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development May 31, 2026
@pkg-pr-new

pkg-pr-new Bot commented May 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8689

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8689

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8689

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8689

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8689

commit: a8509c1

@github-actions

github-actions Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a8509c1

@Varixo Varixo force-pushed the v2-streaming-fix branch from c29a743 to 3f45071 Compare May 31, 2026 13:49
@Varixo Varixo linked an issue May 31, 2026 that may be closed by this pull request
@Varixo Varixo force-pushed the v2-streaming-fix branch from 3f45071 to 383f4ad Compare May 31, 2026 14:11
@Varixo Varixo force-pushed the v2-streaming-fix branch from 383f4ad to a8509c1 Compare May 31, 2026 14:57

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛸

In a small way it's a breaking change because V2 containers of older beta versions won't work with the new qwikloader but that's probably not an issue.

@wmertens wmertens merged commit 0f0553b into build/v2 Jun 5, 2026
31 checks passed
@wmertens wmertens deleted the v2-streaming-fix branch June 5, 2026 05:12
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[🐞] [V2] vnode Missing_child

3 participants