Skip to content

fix(router): const assignment in route loaders#8709

Merged
wmertens merged 1 commit into
build/v2from
v2-const-assign-route-loader
Jun 9, 2026
Merged

fix(router): const assignment in route loaders#8709
wmertens merged 1 commit into
build/v2from
v2-const-assign-route-loader

Conversation

@Varixo

@Varixo Varixo commented Jun 9, 2026

Copy link
Copy Markdown
Member

Fixes routeLoader$ filtered search caching by storing the last filtered search and route path in a captured object, avoiding "assignment to constant variable" errors after QRL transform

@Varixo Varixo self-assigned this Jun 9, 2026
@Varixo Varixo requested a review from a team as a code owner June 9, 2026 15:21
@Varixo Varixo added the V2 label Jun 9, 2026
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 129a54e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/router Patch
eslint-plugin-qwik Patch
@qwik.dev/core Patch
create-qwik Patch
@qwik.dev/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Jun 9, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8709

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8709

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8709

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8709

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8709

commit: 129a54e

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 129a54e

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 25a76ed into build/v2 Jun 9, 2026
92 of 94 checks passed
@wmertens wmertens deleted the v2-const-assign-route-loader branch June 9, 2026 16:15
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants