Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all usart to their own namespace, code formatting and vscode tasks/intellisense added #13

Merged
merged 8 commits into from May 3, 2019

Conversation

Projects
None yet
2 participants
@itzandroidtab
Copy link
Contributor

commented May 2, 2019

No description provided.

@itzandroidtab itzandroidtab changed the base branch from master to release May 2, 2019

@itzandroidtab

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

changed it to release instead of master. My bad

@PatrickDekker98
Copy link
Contributor

left a comment

Nice work but could some details need a second eye

Show resolved Hide resolved code/headers/uart_ports.hpp
Show resolved Hide resolved code/headers/usart_connection.hpp
Show resolved Hide resolved code/src/hardware_usart.cpp Outdated
@@ -60,6 +60,18 @@ namespace r2d2 {
enable();
}

hardware_usart_c &hardware_usart_c::operator<<(uint8_t byte) {

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 3, 2019

Author Contributor

I accidentally moved this while merging :(

@itzandroidtab itzandroidtab requested a review from PatrickDekker98 May 3, 2019

@itzandroidtab itzandroidtab merged commit fccb253 into release May 3, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itzandroidtab itzandroidtab deleted the feature-own_namespace branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.