Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch changes pr#15 #17

Merged
merged 8 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@PatrickDekker98
Copy link
Contributor

commented May 8, 2019

the requested changes of p#15 were added in this branch, pull to release so pr 15 can pass

PatrickDekker98 and others added some commits Apr 18, 2019

Merge pull request #9 from R2D2-2019/hotfix-put_cpp_in_src
hotfix put cpp in src not headers
Merge pull request #11 from R2D2-2019/feature-makefile.inc
updated readme and makefile.inc to use the tests
changes requested in pr#15 were added test_usart and hardware_usart a…
…re now templated, usart_ports_c is now usart_ports

@PatrickDekker98 PatrickDekker98 requested a review from itzandroidtab May 8, 2019

@itzandroidtab
Copy link
Contributor

left a comment

It looks good but the template things should move to the header

PatrickDekker98 added some commits May 8, 2019

now travis will pass, apearantly templates don't play nice with defin…
…itions in a cpp file so all is defined and declared in the hpp file

@PatrickDekker98 PatrickDekker98 requested a review from itzandroidtab May 8, 2019

unsigned int available() override {
if ((hardware_usart->US_CSR & 1) != 0) {
input_buffer.push(receive_byte());
}

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 8, 2019

Contributor

This bracket is on a strange spot

uart1 = 0,
uart2,
uart3,
// only for determining how many uart ports there are
UART_SIZE
UART_SIZE

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 8, 2019

Contributor

This probably shoulnt move

@PatrickDekker98 PatrickDekker98 requested a review from itzandroidtab May 8, 2019

@PatrickDekker98 PatrickDekker98 merged commit 90c8528 into release May 9, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PatrickDekker98 PatrickDekker98 deleted the patch-changes_pr#15 branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.