Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature module display #14

Merged
merged 10 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@itzandroidtab
Copy link
Contributor

itzandroidtab commented Apr 13, 2019

The start of the module

@itzandroidtab

This comment has been minimized.

Copy link
Contributor Author

itzandroidtab commented Apr 13, 2019

So the build failed on DISPLAY_FILLED_RECTANGLE. So the build env needs to get the new version before we can merge...

Show resolved Hide resolved code/main.cpp Outdated
@florianhumblot
Copy link
Contributor

florianhumblot left a comment

If you remove the unnecessary namespace scoping I'll be able to approve these changes :)

@itzandroidtab itzandroidtab requested a review from florianhumblot Apr 15, 2019

@itzandroidtab itzandroidtab merged commit eb01aef into release Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itzandroidtab itzandroidtab deleted the feature-module_display branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.