Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added display character frame #31

Merged
merged 36 commits into from May 17, 2019

Conversation

Projects
None yet
4 participants
@JensBouman
Copy link

commented May 11, 2019

Until the extended frames are supported, this frame will only process 1 character. Once the extended frame type is available, I will increase the character amount.

@itzandroidtab
Copy link

left a comment

This branch is not up to date with master

Show resolved Hide resolved code/headers/frame_types.hpp Outdated
Show resolved Hide resolved code/headers/frame_types.hpp Outdated
Show resolved Hide resolved code/headers/frame_types.hpp Outdated
@LRstudentHU

This comment has been minimized.

Copy link

commented May 12, 2019

A sidenote: would a cursor-like API be more logical? Currently, you're required to send color and position information in every frame, which is quite inefficient. Maybe you could "request" a cursor and keep an array of cursors within your module. A cursor would keep position, color and maybe some other settings.

I don't know if this is a great idea or what the PO thinks; but I do think we can be more efficient.

JensBouman added some commits May 13, 2019

@wds444

This comment has been minimized.

Copy link

commented May 16, 2019

Extended frames are now supported, if you want you can now increase the size of the packet.

JensBouman added some commits May 16, 2019

@JensBouman JensBouman requested a review from LRstudentHU May 16, 2019

@itzandroidtab

This comment has been minimized.

Copy link

commented on code/headers/frame_types.hpp in 4b0d85c May 16, 2019

The maximum total frame size is 248 bytes.

@JensBouman

This comment has been minimized.

Copy link
Author

commented May 16, 2019

Updated the array size to the maximum.

Show resolved Hide resolved code/headers/frame_types.hpp Outdated
Show resolved Hide resolved code/headers/frame_types.hpp Outdated
Show resolved Hide resolved code/headers/frame_types.hpp

JensBouman added some commits May 16, 2019

@LRstudentHU

This comment has been minimized.

Copy link

commented May 17, 2019

@itzandroidtab this is the first candidate for the string optimisation

JensBouman and others added some commits May 17, 2019

@LRstudentHU LRstudentHU requested a review from itzandroidtab May 17, 2019

JensBouman added some commits May 17, 2019

// Targets which cursor to write to. This should be one
// your module claimed.
uint8_t cursor_id;
uint8_t cursor_x;

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 17, 2019

Can you add what location these cursors have? Direct pixel location or the font location

This comment has been minimized.

Copy link
@JensBouman

JensBouman May 17, 2019

Author

Agreed, fixed in 83f772e

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 17, 2019

The linked commit doesnt add any documentation.

This comment has been minimized.

Copy link
@JensBouman

JensBouman May 17, 2019

Author

You are right, I hastily made the wrong comment to the wrong change, my bad. I will change it soon.

This comment has been minimized.

Copy link
@JensBouman

JensBouman May 17, 2019

Author

Added more documentation about the cursor_id in ce2ae41. If this isn't what you meant, please say so.

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 17, 2019

I meant in hwlib when you write to the screen the location is not directly the pixel you write to. (At leasts when I used it).

So when you wrote to (1, 0) it would write as the second character on the first line. Is this following that principle or can you write to (100, 100) and it will start at pixel (100, 100) and write it from there?

This comment has been minimized.

Copy link
@LRstudentHU

LRstudentHU May 17, 2019

As I read it, this is simply pixel position.

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 17, 2019

Okay sure then it is probably just me.

JensBouman added some commits May 17, 2019

Show resolved Hide resolved code/headers/frame_types.hpp Outdated

@JensBouman JensBouman merged commit 4691ccc into master May 17, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@itzandroidtab itzandroidtab deleted the feature-display_character branch May 17, 2019

@itzandroidtab itzandroidtab added the Frame label May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.