Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended frames #34

Merged
merged 96 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@itzandroidtab
Copy link

commented May 13, 2019

Full support for frames up to 256 bytes.
Also implements a host of optimisations.

Note: due to the nature of the change, tests are kinda working atm.

LRstudentHU and others added some commits Apr 4, 2019

Show resolved Hide resolved code/headers/comm.hpp Outdated
Show resolved Hide resolved code/headers/can.hpp Outdated
Show resolved Hide resolved code/headers/can.hpp Outdated
Show resolved Hide resolved code/headers/channel.hpp Outdated
Show resolved Hide resolved code/headers/channel.hpp Outdated
Show resolved Hide resolved code/headers/channel.hpp Outdated
Show resolved Hide resolved code/headers/channel.hpp
Show resolved Hide resolved code/headers/nfc_mem.hpp
Show resolved Hide resolved code/headers/nfc_mem.hpp Outdated

@florianhumblot florianhumblot self-requested a review May 14, 2019

Show resolved Hide resolved code/headers/base_comm.hpp Outdated
Show resolved Hide resolved code/headers/base_comm.hpp Outdated
Show resolved Hide resolved code/headers/comm.hpp
Show resolved Hide resolved code/headers/nfc_mem.hpp Outdated

@itzandroidtab itzandroidtab requested a review from florianhumblot May 14, 2019

Show resolved Hide resolved code/headers/channel.hpp Outdated
Show resolved Hide resolved code/headers/channel.hpp Outdated
@LRstudentHU
Copy link

left a comment

Ready to merge!

@itzandroidtab

This comment has been minimized.

Copy link
Author

commented May 15, 2019

Ran some last tests and everything works as intended:

https://youtu.be/fj5ITbrXnpY

In this test i changed the x, y, width and heigth to uint16_t of the frame_display_filled_rectangle_s. So the size of the frame was 11 bytes. This was to test the extended frames.

On every arduino due 2 COM's are running (COM1 and COM2). COM1 receives all data on the bus and COM2 only receives DISPLAY_FILLED_RECTANGLE's. COM1 is transmitting the data.

@itzandroidtab itzandroidtab merged commit 570ad07 into master May 15, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@itzandroidtab itzandroidtab deleted the feature-external_comm_frames branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.