Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added frame type for path step #35

Merged
merged 9 commits into from May 16, 2019

Conversation

Projects
None yet
3 participants
@nicovanbentum
Copy link

commented May 15, 2019

No description provided.

@nicovanbentum nicovanbentum requested a review from LRstudentHU May 15, 2019

* Navigation wiki:
* https://github.com/R2D2-2019/R2D2-2019/wiki/Navigation
*/
struct frame_path_step_s {

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 15, 2019

Can you change the order of the variables to have the lowest size at the bottem. And add a

#pragma pack(1)

Before the struct

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab May 15, 2019

This removes the padding from the struct and saves at least 1 byte

This comment has been minimized.

Copy link
@nicovanbentum

nicovanbentum May 15, 2019

Author

both fixed in 2nd last commit. Regarding coordinates, we realize we're not inline with Location detection/Mapping but we have discussed this with Swarm Management and came to the conclusion that it's up to Location Detection to fix their stuff.

@itzandroidtab

This comment has been minimized.

Copy link

commented May 15, 2019

What kind of step is this? Does it give a coordinate to to or does it provide a offset from the current location. What does path_id do? What does the step_id do? Doesnt a location have a north_south/ east_west direction? And a altitude?

@itzandroidtab

This comment has been minimized.

Copy link

commented May 15, 2019

Maybe a coordinate struct in this struct is a better idea

nicovanbentum added some commits May 15, 2019

@LRstudentHU

This comment has been minimized.

Copy link

commented May 16, 2019

Please update from master again

nicovanbentum added some commits May 16, 2019

@nicovanbentum nicovanbentum requested a review from itzandroidtab May 16, 2019

@nicovanbentum nicovanbentum merged commit 9b28e35 into master May 16, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@itzandroidtab itzandroidtab deleted the feature-navigation_frame branch May 18, 2019

@itzandroidtab itzandroidtab added the Frame label May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.