Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add rtttl frame #69

Merged
merged 10 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@PatrickDekker98
Copy link

commented May 28, 2019

an rtttl frame that sends an rtttl string was added :/

@itzandroidtab
Copy link

left a comment

As this is a string this can use the string optimatisation

Patrick Patrick
@LRstudentHU

This comment has been minimized.

Copy link

commented May 29, 2019

As this is a string this can use the string optimatisation

This is actually required before merging. Please look at the characters frame from display for an example.

@PatrickDekker98 PatrickDekker98 requested a review from itzandroidtab May 29, 2019

Patrick and others added some commits May 29, 2019

Show resolved Hide resolved code/headers/frame_types.hpp Outdated
frame_rtttl_string_s,
RTTTL_STRING,
R2D2_OPTIMISE_STRING(frame_rtttl_string_s, rtttl_string)
)

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Jun 3, 2019

This has 8 spaces. Could you change it to 4?

This comment has been minimized.

Copy link
@PatrickDekker98

PatrickDekker98 Jun 3, 2019

Author

should be resolved

@@ -628,6 +629,16 @@ namespace r2d2 {
};

/*
* @brief This is a frame that will be send to the sound module.

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Jun 3, 2019

The @brief and @details should be removed to conform the rest of the file

This comment has been minimized.

Copy link
@PatrickDekker98

PatrickDekker98 Jun 4, 2019

Author

should be resolved

@itzandroidtab itzandroidtab added the Frame label Jun 3, 2019

@PatrickDekker98 PatrickDekker98 requested a review from itzandroidtab Jun 4, 2019

LRstudentHU and others added some commits Jun 5, 2019

@PatrickDekker98 PatrickDekker98 merged commit f8f16f5 into master Jun 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@itzandroidtab itzandroidtab deleted the feature-rtttl_frame branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.