Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parse nmea function #6

Merged
merged 62 commits into from Jun 4, 2019

Conversation

Projects
None yet
7 participants
@itzandroidtab
Copy link

commented Jun 4, 2019

No description provided.

@streefje1996

This comment has been minimized.

Copy link

commented on 831124b May 17, 2019

for class diagram reference see: https://drive.google.com/open?id=1mMdPIAQqadgT6fmVWsLVA1Dnb0JzsxD6

  • parse.cpp and main.cpp contain the exact same code;
  • parse() is a function from abstract class: location_detection_c;
  • struct location_s needs to be updated according to class diagram;
  • time_maker function looks good maybe a different name would be better but it looks good, maybe write some tests to see if it outputs what you think it should;
  • latitude_longitude_maker needs to be updated to work with floats instead
  • in the parser function, maybe try editing the sizes of your temp values like hwlib::string<10> north_or_south_temp; could be hwlib::string<1> north_or_south_temp; since it only contains one char, maybe even change it to a single char;
  • comma delimiter looks alright, maybe write some tests;

in general:

  • don't forget to add the r2d2 namespace
  • don't forget to implement the function from the abstract class
  • don't place an int main in source code from a class

Keep up the good work :)

ThePatman3 and others added some commits May 24, 2019

Working on the implementation of the location detection module
Specifically the get_location() and compress() functions are being worked on. As well as doxygen documentation for multiple headers.
Working on the process() function of location_detector
It isn't finished yet, because we do not know what frame we are listening for.
Merge pull request #4 from R2D2-2019/feature-uart_nmea_class
Merging functions with nmea class

@MarcDirven MarcDirven self-requested a review Jun 4, 2019

Show resolved Hide resolved code/headers/gga.hpp
Show resolved Hide resolved code/headers/nmea_listener.hpp Outdated
Show resolved Hide resolved code/main.cpp Outdated
Show resolved Hide resolved code/src/nmea_parser.cpp Outdated

@itzandroidtab itzandroidtab merged commit 8c38329 into release Jun 4, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itzandroidtab itzandroidtab deleted the feature-parse_nmea_function branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.