Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed includes/filenames/namespaceusage/wrong variable type #2

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@Slimmerik
Copy link

commented Mar 30, 2019

No description provided.

@@ -25,7 +25,7 @@ namespace r2d2::robot_arm {
* @param z
* @return bool
*/
void move_head_to_coordinate(const uint16_t &x, const uint16_t &y, const uint16_t &z) {
void move_head_to_coordinate(const int16_t &x, const int16_t &y, const int16_t &z) {

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Apr 5, 2019

Why is the interface getting a update in a pr for a build environment pr?

@@ -0,0 +1,67 @@
/**

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Apr 5, 2019

This file should get its own feature-branch

#include "robot_arm_interface_c.h"
#include "test_arm_c.h"
#include <hwlib.hpp>
#include <../headers/robot_arm_interface_c.hpp>

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Apr 5, 2019

This should move to a different branch as well and you dont need to add the folder to the include if the makefile is correct

"../headers" <-- This part

@@ -1,7 +1,7 @@
#include "test_arm_c.h"
#include <../headers/test_arm_c.hpp>

This comment has been minimized.

Copy link
@itzandroidtab

itzandroidtab Apr 5, 2019

needs to move to that new branch as well

@Slimmerik Slimmerik closed this Apr 9, 2019

@Timvdijk Timvdijk deleted the hotfix-buildEnvUpdate branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.