Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature update interval #5

Merged
merged 15 commits into from Dec 31, 2017
Merged

[WIP] Feature update interval #5

merged 15 commits into from Dec 31, 2017

Conversation

@vgonisanz
Copy link
Collaborator

vgonisanz commented Dec 30, 2017

[WIP] = Work in progress.

Hi. I create a pull request to discuss about add this new feature to pycoinmon.

  • Moved parse arguments to init function. ✔️
  • Refactor methods needed to avoid repeat code lines with new code. ✔️
  • Added argument to refresh each x second data provided by CoinMarketCap ✔️

Need to clear how:

  • Stop the refresh bucle with a valid crossplatform method. ✔️
  • Update data without reprint everytime, in example, using os.system('cls') # on windows or os.system('clear') # on linux / os x ✔️

This feature could be improved, so, comments are welcome.

@RDCH106 RDCH106 changed the title Feature update interval [WIP] Feature update interval Dec 31, 2017
@RDCH106

This comment has been minimized.

Copy link
Owner

RDCH106 commented Dec 31, 2017

Fixed Codacy error --> Restore missing find function

@RDCH106

This comment has been minimized.

Copy link
Owner

RDCH106 commented Dec 31, 2017

  • To abort execution, without extra dependencies, require a kill signal (control + C) ✔️
@vgonisanz

This comment has been minimized.

Copy link
Collaborator Author

vgonisanz commented Dec 31, 2017

Awesome. I think that the features is completed!

@RDCH106 RDCH106 changed the base branch from master to develop Dec 31, 2017
@RDCH106 RDCH106 merged commit 2870b7b into develop Dec 31, 2017
3 checks passed
3 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@RDCH106 RDCH106 deleted the feature_update_interval branch Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.