Skip to content

[WIP] Feature update interval#5

Merged
RDCH106 merged 15 commits intodevelopfrom
feature_update_interval
Dec 31, 2017
Merged

[WIP] Feature update interval#5
RDCH106 merged 15 commits intodevelopfrom
feature_update_interval

Conversation

@vgonisanz
Copy link
Collaborator

@vgonisanz vgonisanz commented Dec 30, 2017

[WIP] = Work in progress.

Hi. I create a pull request to discuss about add this new feature to pycoinmon.

  • Moved parse arguments to init function. ✔️
  • Refactor methods needed to avoid repeat code lines with new code. ✔️
  • Added argument to refresh each x second data provided by CoinMarketCap ✔️

Need to clear how:

  • Stop the refresh bucle with a valid crossplatform method. ✔️
  • Update data without reprint everytime, in example, using os.system('cls') # on windows or os.system('clear') # on linux / os x ✔️

This feature could be improved, so, comments are welcome.

@RDCH106 RDCH106 changed the title Feature update interval [WIP] Feature update interval Dec 31, 2017
@RDCH106
Copy link
Owner

RDCH106 commented Dec 31, 2017

Fixed Codacy error --> Restore missing find function

@RDCH106
Copy link
Owner

RDCH106 commented Dec 31, 2017

  • To abort execution, without extra dependencies, require a kill signal (control + C) ✔️

@vgonisanz
Copy link
Collaborator Author

Awesome. I think that the features is completed!

@RDCH106 RDCH106 changed the base branch from master to develop December 31, 2017 11:07
@RDCH106 RDCH106 merged commit 2870b7b into develop Dec 31, 2017
@RDCH106 RDCH106 deleted the feature_update_interval branch January 14, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants