Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unit-testing invocation #19

Closed
adamhadani opened this issue Sep 22, 2016 · 1 comment
Closed

Cleanup unit-testing invocation #19

adamhadani opened this issue Sep 22, 2016 · 1 comment

Comments

@adamhadani
Copy link
Contributor

Currently we have the following:

  1. a tox.ini file for running tests with the Tox test runner
  2. a run_tests.py and run_tests_py3.sh wrapper scripts for running tests using nose, along with a skiptests.list file which seems to be empty / not used?
  3. a .travis.yml configuration file for Travis CI which sets up dependencies / environment and invokes nosetests directly, along with associated requirements-py{2,3}.txt files

I would suggest we consolidate all of these to use tox so that a single tox.ini file contains all the definitions and dependencies required to run all unit-tests locally as well as in CI, so that travis CI's configuration file can be reduced to simply setting up tox and invoking it. We should be able to get rid of a few of the above files / definitions and make it clearer how to actually run unit-tests.

Along those lines, I would also consider adding running flake8 (Python linter / style checker) as part of running unit-tests on CI, this will help catch common issues early on (e.g unused imports/variables)

@adamhadani
Copy link
Contributor Author

Fixed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant