Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugFix: GraphView, null renderer cause various crash #32

Merged
merged 2 commits into from Oct 12, 2019

Conversation

@Krnlsoft
Copy link
Contributor

Krnlsoft commented Oct 11, 2019

GraphView: setSelectBlock, trigger selectedItemChangeEvent

When switching between disassembler view to graph view is necessary to trigger the selectedItemChanged so that setCurrentRenderer is initialized correctly.

If you don't do this, many disassembler actions fails causing app crash.

DisassemblerGraphView: selectedItemChangedEvent null renderer

It's better to not reset the current renderer, cause many function inside DisassemblerActions fails or need a null check on the renderer.

Infact It's not possible to clear the current selection, so I think it makes sense to keep the previous valid renderer.

Thanks for your time.
Have a nice day.

Krnlsoft added 2 commits Oct 11, 2019
When switching between disassembler view to graph view is necessary to trigger the selectedItemChanged so that setCurrentRenderer is processed correctly
It's better to not reset the current renderer, cause many function inside DisassemblerActions fails or need a null check on the renderer.
@Dax89 Dax89 merged commit 2bb5107 into REDasmOrg:noplugin Oct 12, 2019
fengjixuchui added a commit to fengjixuchui/REDasm that referenced this pull request Oct 14, 2019
Merge pull request REDasmOrg#32 from Krnlsoft/noplugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.