Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclosure implementation: closes #13 #26

Merged
merged 5 commits into from Mar 14, 2021
Merged

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added the epic Epic task covering multiple steps of implementation label Mar 9, 2021
@dr-orlovsky dr-orlovsky added this to the v0.5.0 milestone Mar 9, 2021
@dr-orlovsky dr-orlovsky self-assigned this Mar 9, 2021
@dr-orlovsky dr-orlovsky added this to To Do in RGBv1 Mar 9, 2021
@dr-orlovsky dr-orlovsky added this to Solution WIP in Quality Assesment Mar 9, 2021
@rajarshimaitra
Copy link
Contributor

rajarshimaitra commented Mar 10, 2021

Concept ACK.

Suggestion: I couldn't find the purpose of this structure written anywhere. It would be better to have the purpose of the Disclosure documented here in this PR or somewhere else, as it will guide the implementation and future reviews.

What I mean is,

  1. documenting the transitions and extensions fields inside Disclosure and explain why and which data from stash are to be included here to create a Disclosure.

  2. Use of Disclosure in general, and how it is related to Transfering from multi-asset outputs: closes #143 rgb-node#148

The best approach would be to include them inside the code doc itself. So future developers can reason with the structure.

This is just a TODO. We can do this after the finalization of the implementations.

UkolovaOlga added a commit to LNP-BP/devcalls that referenced this pull request Mar 11, 2021
Agenda:
- Double consignments updates
- Disclosures: RGB-WG/rgb-core#26
- Multiple asset transfers RGB-WG/rgb-node#148
- Revealed-merge procedure RGB-WG/rgb-core#23
- Command-line tools:
     * PSBT
     * RGB
     * Invoice
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #26 (61cd091) into master (df9b4d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #26   +/-   ##
======================================
  Coverage    21.9%   21.9%           
======================================
  Files          20      20           
  Lines        1153    1153           
======================================
  Hits          252     252           
  Misses        901     901           
Impacted Files Coverage Δ
src/bech32.rs 100.0% <ø> (ø)
src/lib.rs 50.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9b4d6...ba3bba1. Read the comment docs.

@dr-orlovsky dr-orlovsky marked this pull request as ready for review March 14, 2021 20:44
@dr-orlovsky dr-orlovsky merged commit ac08c8d into master Mar 14, 2021
Quality Assesment automation moved this from Solution WIP to Done Mar 14, 2021
@dr-orlovsky dr-orlovsky deleted the feat-disclosure branch May 14, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epic task covering multiple steps of implementation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants