Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

Reveal seal definition of previously known Transition data #137

Closed
wants to merge 1 commit into from
Closed

Reveal seal definition of previously known Transition data #137

wants to merge 1 commit into from

Conversation

rajarshimaitra
Copy link
Contributor

This is a draft PR, for approach comments and discussion.

This looks for previously known transition data from stash.

Reveals the seal of incoming consignment data corresponding to previously known seals.

Ref #136 (comment)

to previously known revelaed seals in transition data.
@dr-orlovsky dr-orlovsky added this to Solution WIP in Quality Assesment Feb 24, 2021
UkolovaOlga added a commit to LNP-BP/devcalls that referenced this pull request Feb 26, 2021
Agenda:

1. Development updates from @dr-orlovsky:
     - wallet architecture advancements
     - plans & roadmap for more testing command-line, tx-generation and wallet-based tools
2. Recap on transition mutability refactoring of the previous week
3. Review of quality assurance issues from https://github.com/orgs/rgb-org/projects/11, pay special attention to consignment merges
4. Priorities for further development process
5. Developer Q&As
6. Update Stash merge logic to account for previously known transition data. This is a security vulnerability and can cause fund loss.
Ref: RGB-WG/rgb-node#136 (comment)
Ref PR: RGB-WG/rgb-node#137 (comment)
@dr-orlovsky dr-orlovsky changed the title Revela seal definition of previously known Transition data Reveal seal definition of previously known Transition data Mar 4, 2021
@dr-orlovsky dr-orlovsky added this to the 0.4.0 milestone Mar 4, 2021
@dr-orlovsky dr-orlovsky added bug Something isn't working enhancement Improvement to existing functionality or refactoring *security* Security-related issues labels Mar 4, 2021
@dr-orlovsky dr-orlovsky marked this pull request as draft March 17, 2021 08:28
@rajarshimaitra
Copy link
Contributor Author

Closing this PR.

Quality Assesment automation moved this from Solution WIP to Rejected solutions Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement Improvement to existing functionality or refactoring *security* Security-related issues
Projects
No open projects
Quality Assesment
Rejected solutions
Development

Successfully merging this pull request may close these issues.

None yet

2 participants