Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation sequqence diagram mermaid file and png #2

Closed
wants to merge 3 commits into from
Closed

Validation sequqence diagram mermaid file and png #2

wants to merge 3 commits into from

Conversation

rajarshimaitra
Copy link
Contributor

No description provided.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


rect rgba(255, 204, 255)
activate stashd
Note over stashd: Consignment genesis added <br> without checking Status?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incorrect behavior: we should not accept genesis unless the user explicitly decides to do so. Can you pls open an issue or do a PR fixing this?


rect rgba(255, 204, 255)
activate fund
Note over fund: Doesn't check for Reply::ValidationStatus?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with RGB-WG/rgb-node#132

@dr-orlovsky dr-orlovsky added the documentation Improvements or additions to documentation label Feb 10, 2021
@dr-orlovsky dr-orlovsky added this to Review reports in Quality Assesment Feb 10, 2021
UkolovaOlga referenced this pull request in LNP-BP/devcalls Feb 17, 2021
10.02.2021 Agenda:
RGB QA

Issues from https://github.com/orgs/rgb-org/projects/11:

1. Properly handle result from 'validate' request to Stash daemon - RGB-WG/rgb-node#132
2. Asset state transition node ID mutability
    - https://github.com/rgb-org/rgb-node/issues/133
    - RGB-WG/rgb-node#131
    - Asset transfer validation is ineffective: RGB-WG/rgb-node#130
3. Question about fungible asset known allocations semantics - RGB-WG/rgb-node#134
4. Transfer change allocation not being registered - RGB-WG/rgb-node#129
5. Transaction output duplicated by 'fungible transfer' - RGB-WG/rgb-node#127
@dr-orlovsky dr-orlovsky closed this Jun 4, 2022
Quality Assesment automation moved this from Review reports to Rejected solutions Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Quality Assesment
Rejected solutions
Development

Successfully merging this pull request may close these issues.

None yet

2 participants