Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[R] broke code out into individual files (fixes #243) #266
Conversation
|
it depends on the purpose of |
|
@jameslamb That's true. Leaving the decision for @mlampros, since he is the maintainer of R-package. |
|
From the perspective of a user the only case that I can think, is when someone intends to search for a code snippet in the files. Previously, for instance I had to search in 3 files whereas now in multiple. On the other hand if someone intends to use the functions of the package (after installation) then he/she will not see any difference at all. I mostly write such changes in the NEWS.md file, but I guess, now I'm not the only contributor for the R package in the RGF-team repository. |
|
IMHO a non-developer "user" doesn't need to ever look at scripts or search through them, since you can always run a function without parentheses in R and see the source code printed in the console. Either way, if you tell me to update |
|
It depends. When I started learning R I didn't know that I was able to run a function without parentheses, as you said, so that I can have a look to the code. Moreover, I think it's also a matter of preference. Some people prefer to view the code in the files directly (like myself) and others don't. |
|
Makes sense to me! I just added the update to |
|
thanks |
|
Thanks a lot for your contribution! |
Per #243, in this PR I propose breaking out classes and functions into individual script files. This can make the code a little easier to navigate and diffs in PRs easier to read.