Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[R] change internal calls to use keyword args #267
Conversation
|
@jameslamb Thank you very much! Unfortunately, Travis is unhappy. Can you please take a look? |
|
yep! The fact that it passed on appveyor tells me it's probably just one of those transient travis things. I'll check. |
|
Ha I was too quick to blame Travis. Totally my fault! The package uses |
|
We haven't configured Appveyor for checking R-package yet :-( Seems to be another one typo: |
|
whoops! Fixed. I also created #268 so anyone coming to the repo knows appveyor setup is a contribution that would be welcomed. |
|
Rebasing right now, now that we've merged #266 |
|
ok @StrikerRUS @mlampros this is ready for review! |
|
LGTM! |
|
Oh sure, no prob. Just updated the |
|
thanks |
This PR addresses #244
Please do not review until we've merged #266 . I branched off of that PR to avoid dealing with merge conflicts. If/when we merge that, I'll rebase this PR and the diff will make more sense.