From c59e17ea1956141d9555724660229b462f1ff383 Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 22:24:21 +0530 Subject: [PATCH 1/8] drivers/include/bmx055.h : Expose Parameters Add ifndef and Expose Compile Parameters to Doxyen --- drivers/include/bmx055.h | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/include/bmx055.h b/drivers/include/bmx055.h index 9eca87ee26c3..bb33fb955d81 100644 --- a/drivers/include/bmx055.h +++ b/drivers/include/bmx055.h @@ -36,12 +36,39 @@ extern "C" { #endif /** - * @name The sensors default I2C addresses + * @defgroup drivers_bmx055_config BMX055 sensor driver compile configuration + * @ingroup config_drivers_sensors * @{ */ +/** + * @brief Magnetometer default address + * + * The address depends on part number of SDO1, SDO2 and CSB3. + * For more information on SerialBus Address, refer section 11.2 in datasheet. + */ +#ifndef BMX055_MAG_ADDR_DEFAULT #define BMX055_MAG_ADDR_DEFAULT (0x10U) +#endif + +/** + * @brief Accelerometer default address + * + * The address depends on part number of SDO1, SDO2 and CSB3. + * For more information on SerialBus Address, refer section 11.2 in datasheet. + */ +#ifndef BMX055_ACC_ADDR_DEFAULT #define BMX055_ACC_ADDR_DEFAULT (0x18U) +#endif + +/** + * @brief Gyroscope default address + * + * The address depends on part number of SDO1, SDO2 and CSB3. + * For more information on SerialBus Address, refer section 11.2 in datasheet. + */ +#ifndef BMX055_GYRO_ADDR_DEFAULT #define BMX055_GYRO_ADDR_DEFAULT (0x68U) +#endif /** @} */ /** From 1e6c0e393560319bd0e9bf8304108027fab9fe7d Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 22:36:36 +0530 Subject: [PATCH 2/8] drivers/include/ds1307.h : Remove ifndef for I2C --- drivers/include/ds1307.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/include/ds1307.h b/drivers/include/ds1307.h index f3b578358f9b..2db8717afd04 100644 --- a/drivers/include/ds1307.h +++ b/drivers/include/ds1307.h @@ -34,9 +34,7 @@ extern "C" { /** * @brief I2C address of DS1307 RTC */ -#ifndef DS1307_I2C_ADDRESS #define DS1307_I2C_ADDRESS (0x68) -#endif /** * @defgroup drivers_ds1307_config DS1307 RTC driver compile configuration From 6757d97766a35395d0400336354e16b1b62104e3 Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 22:37:47 +0530 Subject: [PATCH 3/8] drivers/include/hts221.h : Remove ifndef for I2C --- drivers/include/hts221.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/include/hts221.h b/drivers/include/hts221.h index 385653c69fa4..96ef0f00ce8d 100644 --- a/drivers/include/hts221.h +++ b/drivers/include/hts221.h @@ -36,9 +36,7 @@ extern "C" { /** * @brief Default I2C bus address (7 Bit) of HTS221 devices */ -#ifndef HTS221_I2C_ADDRESS #define HTS221_I2C_ADDRESS (0x5F) -#endif /** * @brief Parameters needed for device initialization From e2b3175a1cab50e7b5d81b686416f0d01f43f636 Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 22:39:51 +0530 Subject: [PATCH 4/8] drivers/include/isl29020.h : Expose Parameters Add ifndef and Expose Compile Parameters to Doxyen --- drivers/include/isl29020.h | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/include/isl29020.h b/drivers/include/isl29020.h index 3fdf5743844c..a290a931584f 100644 --- a/drivers/include/isl29020.h +++ b/drivers/include/isl29020.h @@ -31,10 +31,23 @@ extern "C" { #endif - /** - * @brief The sensors default I2C address - */ +/** + * @defgroup drivers_isl29020_config ISL29020 light sensor driver compile configuration + * @ingroup config_drivers_sensors + * @{ + */ +/** + * @brief Default address + * + * The address depends on the status of A0 Pin. + * Default address corresponds to A0 connected to GND. + * For more information on SerialBus Address, refer Section I2C + * Interface on Page 3 of datasheet. + */ +#ifndef ISL29020_DEFAULT_ADDRESS #define ISL29020_DEFAULT_ADDRESS 0x44 +#endif +/** @} */ /** * @brief Possible modes for the ISL29020 sensor From f705b0e5afd823e3946bb9972c8f60c6d557778a Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 22:54:07 +0530 Subject: [PATCH 5/8] drivers/include/l3g4200d.h : Expose Parameters Add ifndef and Expose Compile Parameters to Doxyen --- drivers/include/l3g4200d.h | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/include/l3g4200d.h b/drivers/include/l3g4200d.h index 2e39cf9a8647..27d40c2d8457 100644 --- a/drivers/include/l3g4200d.h +++ b/drivers/include/l3g4200d.h @@ -37,9 +37,22 @@ #endif /** - * @brief The sensors default I2C address + * @defgroup drivers_l3g4200d_config L3G4200D gyroscope driver compile configuration + * @ingroup config_drivers_sensors + * @{ + */ +/** + * @brief Default address + * + * The address depends on the status of SDO Pin. + * Default address corresponds to SD0 connected to GND. + * For more information on SerialBus Address, refer Section 5.1.1 + * I2C Operation on datasheet. */ +#ifndef L3G4200D_DEFAULT_ADDRESS #define L3G4200D_DEFAULT_ADDRESS 0x68 +#endif +/** @} */ /** * @brief Result vector for gyro measurement From c6f55b6f81f4df2678b0d34ed4fd8cfc99a2cc1f Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 23:13:20 +0530 Subject: [PATCH 6/8] drivers/include/lpsxxx.h : Expose Parameters Add ifndef and Expose Compile Parameters to Doxyen Co-Authored-By: Leandro Lanzieri --- drivers/include/lpsxxx.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/include/lpsxxx.h b/drivers/include/lpsxxx.h index 9736302e2507..846eb56ac1a4 100644 --- a/drivers/include/lpsxxx.h +++ b/drivers/include/lpsxxx.h @@ -36,13 +36,22 @@ extern "C" { #include #include "periph/i2c.h" +/** + * @defgroup drivers_lpsxxx_config LPS331AP/LPS25HB/LPS22HB driver compile configuration + * @ingroup config_drivers_sensors + * @{ + */ /** * @brief The sensors default I2C address * * Default address corresponds to SDO/SA0 pad connected to ground. If SDO/SA0 * pad is connected to power supply, I2C address is 0x5C. + * Refer to 'I2C Operation' section on the datasheet */ +#ifndef LPSXXX_DEFAULT_ADDRESS #define LPSXXX_DEFAULT_ADDRESS (0x5d) +#endif +/** @} */ /** * @brief Return codes From de5db5c99d555d8c5e176abeedece347c440b9fb Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 23:23:41 +0530 Subject: [PATCH 7/8] drivers/include/mpl3115a2.h : Remove ifndef for I2C --- drivers/include/mpl3115a2.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/include/mpl3115a2.h b/drivers/include/mpl3115a2.h index 1ab7f0814106..a87b044670c0 100644 --- a/drivers/include/mpl3115a2.h +++ b/drivers/include/mpl3115a2.h @@ -50,12 +50,10 @@ enum { MPL3115A2_ERROR_CNF, /**< Device configuration failed */ }; -#ifndef MPL3115A2_I2C_ADDRESS /** * @brief MPL3115A2 Default Address */ #define MPL3115A2_I2C_ADDRESS (0x60) -#endif /** * @name Oversample Ratio configuration From b75fc0cfa6afa81e1fde88e66ecded8a3a106167 Mon Sep 17 00:00:00 2001 From: Akshai M Date: Tue, 7 Apr 2020 23:25:11 +0530 Subject: [PATCH 8/8] drivers/include/tcs37727.h : Remove ifndef for I2C Remove ifndef and better formatting for Doxygen --- drivers/include/tcs37727.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/include/tcs37727.h b/drivers/include/tcs37727.h index b0f444291a13..a9b228bce3ca 100644 --- a/drivers/include/tcs37727.h +++ b/drivers/include/tcs37727.h @@ -36,9 +36,10 @@ extern "C" { #endif -#ifndef TCS37727_I2C_ADDRESS -#define TCS37727_I2C_ADDRESS 0x29 /**< Default Device Address */ -#endif +/** + * @brief Default Device Address + */ +#define TCS37727_I2C_ADDRESS 0x29 /** * @defgroup drivers_tcs37727_config TCS37727 RGB Light Sensor driver compile configuration