stm32: GPIO driver implementation uses magic numbers

[jnohlgard]

Example:

RIOT/cpu/stm32f0/periph/gpio.c

Line 119 in df99604

SYSCFG->EXTICR[pin_num >> 2] &= ~(0xf << ((pin_num & 0x03) * 4));

These can lead to hard to find bugs and should be changed to preprocessor constants.

[PeterKietzmann]

That looks like a task for @A-Paul :-) ???

[A-Paul]

@PeterKietzmann, do you want me to be assigned to this issue?

[PeterKietzmann]

@A-Paul no matter about the assignment. IIRC you once wanted to start an offensive to eliminate all magic numbers :-)

[A-Paul]

@PeterKietzmann, in my opinion the use of numeric literals leads to some problems and should be avoided. Although I'm not feeling to be in charge of cleaning them up... ;)

[A-Paul]

This issue has been announced in #4862 as a reminder for @haukepetersen. Are you going to address this?

[DipSwitch]

I'm gonna regret this... But I think I know fix the magic numbers using the STM32 header files... Only for STM ofcourse =)

[haukepetersen]

I am not going to address this anytime soon, as I personally don't have that strong opinions against magic numbers at certain places...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

[aabadie]

This is still an issue and could be fixed with new CMSIS headers. I think all STM32 cpu uses the new CMSIS versions now.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.