Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saml1x: enable pm_layered by default #11563

Merged
merged 3 commits into from May 24, 2019

Conversation

@dylad
Copy link
Member

commented May 22, 2019

Contribution description

This PR enables pm_layered module by default for SAML10 and SAML11 MCUs.

Testing procedure

Use the usual testing procedure for power management.

Issues/PRs references

should fix a bug for #11346

@dylad dylad requested a review from aabadie May 24, 2019
@aabadie

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

I tested this PR yesterday using tests/periph_pm and found that the switch the deep sleep wasn't very stable. Do you have a precise procedure so I can try to reproduce your use case ?

On my side, using the tests/periph_pm shell, I tried unblock_rtc 1 5 but it had no effect and a second call to this command was raising a failed assertion.
Using unblock_rtc 1 5, I was able to switch to low-power only after calling the function twice.

Do you have any idea what could be wrong or if it's expected ?

@dylad

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

I'll investigate further and try to reproduce.

@dylad

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

I put the CPU in idle mode by default now, you can use rtc_unblock 0 5 to reach standby mode for 5 seconds and it'll switch back to idle right after.

Copy link
Contributor

left a comment

I was able to put the board in deep sleep mode with the last commit. tests/periph_pm works the way it should.

Just to be sure nothing was broken, I also ran ./dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . saml11-xpro --jobs=4 and got the following results:
`
Failures during test:

I re-ran tests/periph_rtc and after that it worked. I don't know what went wrong the first time. The others are already failing on master.

ACK

@aabadie

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Please fix the trailing whitespaces to make the CI happy, you can squash directly.

@dylad dylad force-pushed the dylad:pr/saml1x/pm_layered branch from ffc62b1 to 0da43ba May 24, 2019
@dylad

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Done.

@aabadie

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Let's go then!

@aabadie aabadie merged commit 1dcd3b6 into RIOT-OS:master May 24, 2019
2 checks passed
2 checks passed
Murdock The build succeeded. runtime: 14m:13s
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dylad dylad deleted the dylad:pr/saml1x/pm_layered branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.