New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/efm32: move LOW_POWER_ENABLED to efm32-features.mk #12322
cpu/efm32: move LOW_POWER_ENABLED to efm32-features.mk #12322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it makes sense to have this easily configurable through the Makefile.
No functional changes.
Murdock is complaining that Guard that function with the same Actually, this is pretty long, so better use something like #if EFM32_LEUART_ENABLED && defined(LEUART_COUNT) && LEUART_COUNT > 0
#define USE_LEUART
#endif
…
#ifdef USE_LEUART
… |
9e5087b
to
9f0b1a8
Compare
Looks much better now, please squash! :) Murdock found a trailing whitespace, remove it while you're squashing. |
9f0b1a8
to
6a17cb7
Compare
Squashed, and fixed the trailing whitespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reason as before.
No functional changes, just moves config option to Make variable.
Thanks! |
Contribution description
This PR moves
LOW_POWER_ENABLED
to a feature inefm32-features.mk
. This 'centralizes' all (low-level) tunables at one place, and now allows one to simply add it to a Makefile.I renamed this to
EFM32_LEUART_ENABLED
so it is clear that it's about the EFM32 CPU.Testing procedure
The test in
tests/cpu_efm32_features
will ensure that it compiles.Issues/PRs references
n/a