Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/efm32: move LOW_POWER_ENABLED to efm32-features.mk #12322

Merged
merged 3 commits into from Sep 30, 2019

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Sep 28, 2019

Contribution description

This PR moves LOW_POWER_ENABLED to a feature in efm32-features.mk. This 'centralizes' all (low-level) tunables at one place, and now allows one to simply add it to a Makefile.

I renamed this to EFM32_LEUART_ENABLED so it is clear that it's about the EFM32 CPU.

Testing procedure

The test in tests/cpu_efm32_features will ensure that it compiles.

Issues/PRs references

n/a

@basilfx basilfx added the Area: boards Area: Board ports label Sep 28, 2019
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 28, 2019
benpicco
benpicco previously approved these changes Sep 29, 2019
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to have this easily configurable through the Makefile.

No functional changes.

@benpicco
Copy link
Contributor

Murdock is complaining that _is_usart() is now unused in tests/cpu_efm32_features.

Guard that function with the same #if EFM32_LEUART_ENABLED && defined(LEUART_COUNT) && LEUART_COUNT > 0 and you should be good to go.

Actually, this is pretty long, so better use something like

#if EFM32_LEUART_ENABLED && defined(LEUART_COUNT) && LEUART_COUNT > 0
#define USE_LEUART
#endif#ifdef USE_LEUART

@benpicco benpicco dismissed their stale review September 29, 2019 17:15

still room for improvement ;)

@basilfx basilfx force-pushed the feature/efm32_low_power_feature branch from 9e5087b to 9f0b1a8 Compare September 29, 2019 20:44
cpu/efm32/doc.txt Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

Looks much better now, please squash! :)

Murdock found a trailing whitespace, remove it while you're squashing.

@basilfx basilfx force-pushed the feature/efm32_low_power_feature branch from 9f0b1a8 to 6a17cb7 Compare September 29, 2019 22:03
@basilfx
Copy link
Member Author

basilfx commented Sep 29, 2019

Squashed, and fixed the trailing whitespace.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason as before.
No functional changes, just moves config option to Make variable.

@benpicco benpicco merged commit 1243955 into RIOT-OS:master Sep 30, 2019
@basilfx
Copy link
Member Author

basilfx commented Sep 30, 2019

Thanks!

@basilfx basilfx deleted the feature/efm32_low_power_feature branch October 1, 2019 12:58
@kb2ma kb2ma added this to the Release 2019.10 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants