Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/saml21-xpro: configure UART & SPI on EXT2, 3 #16694

Merged
merged 1 commit into from Jul 30, 2021
Merged

boards/saml21-xpro: configure UART & SPI on EXT2, 3 #16694

merged 1 commit into from Jul 30, 2021

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jul 30, 2021 •
edited

Contribution description

This adds the missing configuration for I2C and UART on EXT2/3

Testing procedure

connect RX to TX and MISO to MOSI and run tests/periph_uart and tests/periph_spi for the new instances.

Issues/PRs references

@benpicco benpicco requested a review from dylad as a code owner July 30, 2021 09:46
@benpicco benpicco added Area: boards Area: Board ports Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 30, 2021
dylad
dylad requested changes Jul 30, 2021
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise looks good.

boards/saml21-xpro/include/periph_conf.h Outdated
Comment on lines 184 to 185
.tx_trigger = SERCOM0_DMAC_ID_TX,
.rx_trigger = SERCOM0_DMAC_ID_RX,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Suggested change
.tx_trigger = SERCOM0_DMAC_ID_TX,
.rx_trigger = SERCOM0_DMAC_ID_RX,
.tx_trigger = SERCOM5_DMAC_ID_TX,
.rx_trigger = SERCOM5_DMAC_ID_RX,

Copy link
Contributor Author

@benpicco benpicco Jul 30, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Actually SERCOM5 doesn't support DMA

@dylad dylad added this to the Release 2021.10 milestone Jul 30, 2021
dylad
dylad approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
Tested the new SPI in loopback and UART_DEV(2) with UART_DEV(1)
Works like a charm.

@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 30, 2021
@dylad dylad merged commit 54a76ab into RIOT-OS:master Jul 30, 2021
@benpicco benpicco deleted the boards/saml21-xpro_EXT3 branch July 30, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benpicco @dylad