boards/remote-*: drop custom led_init() #19348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A custom rainbow boot-up animation/delay gets old pretty quick and we didn't actually init the LEDs anyway, so it would not be shown. Drop the custom led_init() so the generic led_init() kicks in and properly initializes the LEDs.
benpicco
added
Type: bug
MrKevinWeiss
approved these changes
Mar 6, 2023
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
A custom rainbow boot-up animation/delay gets old pretty quick and we didn't actually init the LEDs anyway, so it would not be shown.
Drop the custom
led_init()so the genericled_init()kicks in and properly initializes the LEDs.Testing procedure
examples/blinkyshould work again.Issues/PRs references
https://forum.riot-os.org/t/blinky-for-remote-revb/3892