Skip to content

Conversation

@Lukas-Luger
Copy link
Contributor

Contribution description

This PR adds public key derivation for P256R1 curves using the micro-ecc backend. Unfortunately the Cryptocell 310 does not support this operation.

Testing procedure

The existing test at tests/sys/psa_crypto_ecdsa has been extended to verify the key derivation.

Issues/PRs references

None

@github-actions github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: pkg Area: External package ports Area: sys Area: System labels May 4, 2025
@Teufelchen1 Teufelchen1 requested a review from Einhornhool May 6, 2025 08:40
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 6, 2025
@riot-ci
Copy link

riot-ci commented May 6, 2025

Murdock results

✔️ PASSED

a932a4e tests/sys/psa_crypto_ecdsa: add pub key derivation

Success Failures Total Runtime
10362 0 10363 14m:55s

Artifacts

@mguetschow
Copy link
Contributor

Quoting Murdock

In file included from psa_crypto_algorithm_dispatch.c:34:
include/psa_ecc.h:99:35: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[in]       priv_key_buffer
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:100:34: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[out]      pub_key_buffer
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:101:42: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[in]       priv_key_buffer_length
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:102:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[inout]    pub_key_buffer_length
         ^~~~~~~
include/psa_ecc.h:102:41: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[inout]    pub_key_buffer_length
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
5 errors generated.

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please squash :)

@Lukas-Luger Lukas-Luger force-pushed the pr/psa-ecc-pub-key-derivation branch from 087603b to a932a4e Compare May 27, 2025 06:42
@mguetschow mguetschow added this pull request to the merge queue May 27, 2025
Merged via the queue into RIOT-OS:master with commit 0124fdc May 27, 2025
25 checks passed
@Lukas-Luger Lukas-Luger deleted the pr/psa-ecc-pub-key-derivation branch May 27, 2025 13:07
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: doc Area: Documentation Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants